From: David Miller <davem@davemloft.net>
To: fugang.duan@nxp.com
Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com,
joabreu@synopsys.com, kuba@kernel.org, netdev@vger.kernel.org,
mcoquelin.stm32@gmail.com, p.zabel@pengutronix.de,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net 1/2] net: ethernet: dwmac: add Ethernet glue logic for NXP imx8 chip
Date: Mon, 25 May 2020 18:13:17 -0700 (PDT) [thread overview]
Message-ID: <20200525.181317.1216905484376882401.davem@davemloft.net> (raw)
In-Reply-To: <1590402554-13175-2-git-send-email-fugang.duan@nxp.com>
From: Fugang Duan <fugang.duan@nxp.com>
Date: Mon, 25 May 2020 18:29:13 +0800
> +static int imx_dwmac_init(struct platform_device *pdev, void *priv)
> +{
> + struct imx_priv_data *dwmac = priv;
> + struct plat_stmmacenet_data *plat_dat = dwmac->plat_dat;
> + int ret;
> +
Please code these sequences as:
struct plat_stmmacenet_data *plat_dat;
struct imx_priv_data *dwmac = priv;
int ret;
plat_dat = dwmac->plat_dat;
In order to have reverse christmas three local variable ordering.
THank you.
next prev parent reply other threads:[~2020-05-26 1:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 10:29 [PATCH net 0/2] net: ethernet: dwmac: add Ethernet glue layer for NXP imx8 chip Fugang Duan
2020-05-25 10:29 ` [PATCH net 1/2] net: ethernet: dwmac: add Ethernet glue logic " Fugang Duan
2020-05-26 1:13 ` David Miller [this message]
2020-05-26 1:26 ` [EXT] " Andy Duan
2020-05-25 10:29 ` [PATCH net 2/2] dt-bindings: net: imx-dwmac: Add NXP imx8 DWMAC glue layer Fugang Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525.181317.1216905484376882401.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=fugang.duan@nxp.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).