From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31BA7C433E0 for ; Tue, 26 May 2020 13:40:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F09B22084C for ; Tue, 26 May 2020 13:40:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="SKiKqt4X" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388642AbgEZNkh (ORCPT ); Tue, 26 May 2020 09:40:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728048AbgEZNkh (ORCPT ); Tue, 26 May 2020 09:40:37 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24452C03E96D for ; Tue, 26 May 2020 06:40:37 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id c71so3176761wmd.5 for ; Tue, 26 May 2020 06:40:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xjsoFVyL5ruWU/u4iS6zcPFlWKvH/ECR61WWNc9+T1M=; b=SKiKqt4XdMdR2XAxs2GUjhKSIYnS370cFMqNpRahQFR+G+teAq8pBS2Y6yPyJRMbdg jBNdW9uFs37vLSeG0Z1JOsBXv1pZUuXjwxHAcdSD1XPb9L7U7bEnz+ET1L/gyxxzAZmz fgrlBqi9qn9Tq+6OOVRxtly9oU9PxoJ2+QY7n/g3wUePswzziLCPujIo9UfwViDUofNO P0vUgenPqZu7K7RjJBS5lMkZVXP4FviLkkV0aKa07GF+/Fhkha+XzfCI6SEhB99eRq6a LdD5X/3n0z+NGhzl5dzf6+3OAuUjtqjXL76J7nDetxGXl7bnocMuyFRChs6LzrbpLmJ/ yrWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xjsoFVyL5ruWU/u4iS6zcPFlWKvH/ECR61WWNc9+T1M=; b=dm2P2LkbeBYH5tfYzCnjaWSVopoeGFMHoqteY4oW/ABOm7mXn9e5uJ8l8OIoYumdZj HoJ2cyT3hR3VQygu/DzkMr+8WHs4xEYUryziDUSpkG9YmEaN2U8HEly2b+4WO2Kaa8F/ vpGnZKgvmk2UaqdqqHBgwRDxVrANt1bf5nyiaduyA2tXota3fRKGWV+i+AJzkLWojX+U BoJo9z8L3aiUP1TA4Ipl8Y3Nn6bJwag3tyQc0cNkgvfe79lraFxraOKTR+A0zfu93mr9 /K1W45Ik6Sjko27Y7QjRta0LPqnd0VxW7sNiYXii3KqG87i8I6Dy1UqfOejTcVmtGRDK whdg== X-Gm-Message-State: AOAM532ZfkTP6xJILNJ9EP/qsjLPrAOcp+YDY7CVpxxyW5oTpsU+Yw96 U9FQCEc4Ax+W6ssXTOdYmsRGpfpM6IE= X-Google-Smtp-Source: ABdhPJxNlZwL5cWAH7niFxl9KvgRkton+6fGXkYXmfYSpfeSzdesm2L5a+r1mht6QyIrj91EGo3DvQ== X-Received: by 2002:a1c:544d:: with SMTP id p13mr1576471wmi.25.1590500434538; Tue, 26 May 2020 06:40:34 -0700 (PDT) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id d6sm23403622wrj.90.2020.05.26.06.40.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2020 06:40:33 -0700 (PDT) Date: Tue, 26 May 2020 15:40:32 +0200 From: Jiri Pirko To: Vasundhara Volam Cc: David Miller , Netdev , Jiri Pirko , Michael Chan Subject: Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter. Message-ID: <20200526134032.GD14161@nanopsycho> References: <1590214105-10430-1-git-send-email-vasundhara-v.volam@broadcom.com> <1590214105-10430-2-git-send-email-vasundhara-v.volam@broadcom.com> <20200524045335.GA22938@nanopsycho> <20200525172602.GA14161@nanopsycho> <20200526044727.GB14161@nanopsycho> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Tue, May 26, 2020 at 08:42:28AM CEST, vasundhara-v.volam@broadcom.com wrote: >On Tue, May 26, 2020 at 10:17 AM Jiri Pirko wrote: >> >> Tue, May 26, 2020 at 06:28:59AM CEST, vasundhara-v.volam@broadcom.com wrote: >> >On Mon, May 25, 2020 at 10:56 PM Jiri Pirko wrote: >> >> >> >> Sun, May 24, 2020 at 08:29:56AM CEST, vasundhara-v.volam@broadcom.com wrote: >> >> >On Sun, May 24, 2020 at 10:23 AM Jiri Pirko wrote: >> >> >> >> >> >> Sat, May 23, 2020 at 08:08:22AM CEST, vasundhara-v.volam@broadcom.com wrote: >> >> >> >Add a new "allow_fw_live_reset" generic device bool parameter. When >> >> >> >parameter is set, user is allowed to reset the firmware in real time. >> >> >> > >> >> >> >This parameter is employed to communicate user consent or dissent for >> >> >> >the live reset to happen. A separate command triggers the actual live >> >> >> >reset. >> >> >> > >> >> >> >Cc: Jiri Pirko >> >> >> >Signed-off-by: Vasundhara Volam >> >> >> >Signed-off-by: Michael Chan >> >> >> >--- >> >> >> >v2: Rename param name to "allow_fw_live_reset" from >> >> >> >"enable_hot_fw_reset". >> >> >> >Update documentation for the param in devlink-params.rst file. >> >> >> >--- >> >> >> > Documentation/networking/devlink/devlink-params.rst | 6 ++++++ >> >> >> > include/net/devlink.h | 4 ++++ >> >> >> > net/core/devlink.c | 5 +++++ >> >> >> > 3 files changed, 15 insertions(+) >> >> >> > >> >> >> >diff --git a/Documentation/networking/devlink/devlink-params.rst b/Documentation/networking/devlink/devlink-params.rst >> >> >> >index d075fd0..ad54dfb 100644 >> >> >> >--- a/Documentation/networking/devlink/devlink-params.rst >> >> >> >+++ b/Documentation/networking/devlink/devlink-params.rst >> >> >> >@@ -108,3 +108,9 @@ own name. >> >> >> > * - ``region_snapshot_enable`` >> >> >> > - Boolean >> >> >> > - Enable capture of ``devlink-region`` snapshots. >> >> >> >+ * - ``allow_fw_live_reset`` >> >> >> >+ - Boolean >> >> >> >+ - Firmware live reset allows users to reset the firmware in real time. >> >> >> >+ For example, after firmware upgrade, this feature can immediately reset >> >> >> >+ to run the new firmware without reloading the driver or rebooting the >> >> >> >> >> >> This does not tell me anything about the reset being done on another >> >> >> host. You need to emhasize that, in the name of the param too. >> >> >I am not sure if I completely understand your query. >> >> > >> >> >Reset is actually initiated by one of the PF/host of the device, which >> >> >resets the entire same device. >> >> > >> >> >Reset is not initiated by any other remote device/host. >> >> >> >> Well, in case of multihost system, it might be, right? >> >> >> >In case of multi-host system also, it is one of the host that triggers >> >the reset, which resets the entire same device. I don't think this is >> >remote. >> > >> >As the parameter is a device parameter, it is applicable to the entire >> >device. When a user initiates the reset from any of the host in case >> >of multi-host and any of the PF in case of stand-alone or smartNIC >> >device, the entire device goes for a reset. >> > >> >I will be expanding the description to the following to make it more clear. >> > >> >------------------------ >> >- Firmware live reset allows users to reset the firmware in real time. >> >For example, after firmware upgrade, this feature can immediately >> >reset to run the new firmware without reloading the driver or >> >rebooting the system. >> >When a user initiates the reset from any of the host (in case of >> >multi-host system) / PF (in case of stand-alone or smartNIC device), >> >the entire device goes for a reset when the parameter is enabled. >> >> Sorry, this is still not clear. I think that you are mixing up two >> different things: >> 1) option of devlink reload to indicate that user is interested in "live >> reset" of firmware without reloading driver > >This is the option we are trying to add. If a user is interested in >"live reset", he needs to enable the parameter to enable it in device >capabilities, which is achieved by permanent configuration mode. When >capability is enabled in the device, new firmware which is aware will >allocate the resources and exposes the capability to host drivers. > >But firmware allows the "live reset" only when all the loaded drivers >are aware of/supports the capability. For example, if any of the host >is loaded with an old driver, "live reset" is not allowed until the >driver is upgraded or unloaded. or if the host driver turns it off, >then also "live reset" is not allowed. > >In case of runtime parameter cmode, if any of the host turns off the >capability in the host driver, "live reset" is not allowed until the >driver is unloaded or the user enables it again. > >To make it clear, I can add two parameters. > >1. enable_fw_live_reset - To indicate that the user is interested in >"live reset". This will be a generic param. As I wrote above, I believe this should be an option to "devlink dev reload", not a param. > >2. allow_fw_live_reset - To indicate, if any of the host/PF turns it >off, "live reset" is not allowed. This serves the purpose of what we >are trying to add in runtime cmode. Yeah. >Do you want me to keep it as a driver-specific param? There is nothing driver-specific about this. > >Please let me know if this is clear and makes less confusion. > >Thanks, >Vasundhara > >> 2) devlink param that would indicate "I am okay if someone else (not by >> my devlink instance) resets my firmware". >> >> Could you please split? >> >> >> >------------------------ >> > >> >Thanks, >> >Vasundhara >> >> >> >> > >> >> >Thanks, >> >> >Vasundhara >> >> >> >> >> >> >> >> >> >> >> >> >+ system. >> >> >> >diff --git a/include/net/devlink.h b/include/net/devlink.h >> >> >> >index 8ffc1b5c..488b61c 100644 >> >> >> >--- a/include/net/devlink.h >> >> >> >+++ b/include/net/devlink.h >> >> >> >@@ -406,6 +406,7 @@ enum devlink_param_generic_id { >> >> >> > DEVLINK_PARAM_GENERIC_ID_FW_LOAD_POLICY, >> >> >> > DEVLINK_PARAM_GENERIC_ID_RESET_DEV_ON_DRV_PROBE, >> >> >> > DEVLINK_PARAM_GENERIC_ID_ENABLE_ROCE, >> >> >> >+ DEVLINK_PARAM_GENERIC_ID_ALLOW_FW_LIVE_RESET, >> >> >> > >> >> >> > /* add new param generic ids above here*/ >> >> >> > __DEVLINK_PARAM_GENERIC_ID_MAX, >> >> >> >@@ -443,6 +444,9 @@ enum devlink_param_generic_id { >> >> >> > #define DEVLINK_PARAM_GENERIC_ENABLE_ROCE_NAME "enable_roce" >> >> >> > #define DEVLINK_PARAM_GENERIC_ENABLE_ROCE_TYPE DEVLINK_PARAM_TYPE_BOOL >> >> >> > >> >> >> >+#define DEVLINK_PARAM_GENERIC_ALLOW_FW_LIVE_RESET_NAME "allow_fw_live_reset" >> >> >> >+#define DEVLINK_PARAM_GENERIC_ALLOW_FW_LIVE_RESET_TYPE DEVLINK_PARAM_TYPE_BOOL >> >> >> >+ >> >> >> > #define DEVLINK_PARAM_GENERIC(_id, _cmodes, _get, _set, _validate) \ >> >> >> > { \ >> >> >> > .id = DEVLINK_PARAM_GENERIC_ID_##_id, \ >> >> >> >diff --git a/net/core/devlink.c b/net/core/devlink.c >> >> >> >index 7b76e5f..8544f23 100644 >> >> >> >--- a/net/core/devlink.c >> >> >> >+++ b/net/core/devlink.c >> >> >> >@@ -3011,6 +3011,11 @@ static int devlink_nl_cmd_flash_update(struct sk_buff *skb, >> >> >> > .name = DEVLINK_PARAM_GENERIC_ENABLE_ROCE_NAME, >> >> >> > .type = DEVLINK_PARAM_GENERIC_ENABLE_ROCE_TYPE, >> >> >> > }, >> >> >> >+ { >> >> >> >+ .id = DEVLINK_PARAM_GENERIC_ID_ALLOW_FW_LIVE_RESET, >> >> >> >+ .name = DEVLINK_PARAM_GENERIC_ALLOW_FW_LIVE_RESET_NAME, >> >> >> >+ .type = DEVLINK_PARAM_GENERIC_ALLOW_FW_LIVE_RESET_TYPE, >> >> >> >+ }, >> >> >> > }; >> >> >> > >> >> >> > static int devlink_param_generic_verify(const struct devlink_param *param) >> >> >> >-- >> >> >> >1.8.3.1 >> >> >> >