From: Daniel Borkmann <daniel@iogearbox.net>
To: Eelco Chaudron <echaudro@redhat.com>
Cc: "Andrii Nakryiko" <andrii.nakryiko@gmail.com>,
bpf <bpf@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Networking <netdev@vger.kernel.org>,
"Alexei Starovoitov" <ast@kernel.org>,
"Martin Lau" <kafai@fb.com>, "Song Liu" <songliubraving@fb.com>,
"Yonghong Song" <yhs@fb.com>, "Andrii Nakryiko" <andriin@fb.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>
Subject: Re: [PATCH bpf-next] libbpf: fix perf_buffer__free() API for sparse allocs
Date: Thu, 28 May 2020 15:52:51 +0200 [thread overview]
Message-ID: <20200528135251.GA24961@pc-9.home> (raw)
In-Reply-To: <54F16472-92CB-4A18-BC7D-0DB8741496E4@redhat.com>
On Thu, May 28, 2020 at 09:24:58AM +0200, Eelco Chaudron wrote:
> On 27 May 2020, at 19:58, Andrii Nakryiko wrote:
> > On Wed, May 27, 2020 at 1:42 AM Eelco Chaudron <echaudro@redhat.com>
> > wrote:
> > >
> > > In case the cpu_bufs are sparsely allocated they are not
> > > all free'ed. These changes will fix this.
> > >
> > > Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
> > > ---
> >
> > Thanks a lot!
> >
> > You forgot:
> >
> > Fixes: fb84b8224655 ("libbpf: add perf buffer API")
>
> Thanks, I forgot that :( Daniel do you want me to send a v2, or will you
> add it when you apply it?
No worries, added it. Applied to bpf-next, thanks!
prev parent reply other threads:[~2020-05-28 13:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 8:42 [PATCH bpf-next] libbpf: fix perf_buffer__free() API for sparse allocs Eelco Chaudron
2020-05-27 17:58 ` Andrii Nakryiko
2020-05-28 7:24 ` Eelco Chaudron
2020-05-28 13:52 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528135251.GA24961@pc-9.home \
--to=daniel@iogearbox.net \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=echaudro@redhat.com \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=toke@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).