From: David Miller <davem@davemloft.net>
To: hexie3605@gmail.com
Cc: kuba@kernel.org, madhuparnabhowmik04@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/net/wan/lapbether.c: Fixed kernel panic when used with AF_PACKET sockets
Date: Mon, 01 Jun 2020 11:32:06 -0700 (PDT) [thread overview]
Message-ID: <20200601.113206.2297277969426428314.davem@davemloft.net> (raw)
In-Reply-To: <20200528032134.13752-1-hexie3605@gmail.com>
From: Xie He <hexie3605@gmail.com>
Date: Wed, 27 May 2020 20:21:33 -0700
> When we use "AF_PACKET" sockets to send data directly over LAPB over
> Ethernet using this driver, the kernel will panic because of
> insufficient header space allocated in the "sk_buff" struct.
>
> The header space needs 18 bytes because:
> the lapbether driver will remove a pseudo header of 1 byte;
> the lapb module will prepend the LAPB header of 2 or 3 bytes;
> the lapbether driver will prepend a length field of 2 bytes and the
> Ethernet header of 14 bytes.
>
> So -1 + 3 + 16 = 18.
>
> Signed-off-by: Xie He <hexie3605@gmail.com>
This is not the real problem.
The real problem is that this is a stacked, layered, device and the
lapbether driver does not take the inner device's header length into
consideration. It should take this from the child device's netdev
structure rather than use constants.
Your test case will still fail when lapbether is stacked on top of a
VLAN device or similar, even with your changes.
next prev parent reply other threads:[~2020-06-01 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 3:21 [PATCH] drivers/net/wan/lapbether.c: Fixed kernel panic when used with AF_PACKET sockets Xie He
2020-06-01 18:32 ` David Miller [this message]
2020-06-30 16:01 ` Xie He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200601.113206.2297277969426428314.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hexie3605@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madhuparnabhowmik04@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).