From: kernel test robot <lkp@intel.com>
To: Vinay Kumar Yadav <vinay.yadav@chelsio.com>,
netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org
Cc: kbuild-all@lists.01.org, edumazet@google.com,
borisp@mellanox.com, secdev@chelsio.com,
Vinay Kumar Yadav <vinay.yadav@chelsio.com>
Subject: Re: [PATCH net-next] crypto/chtls: Fix compile error when CONFIG_IPV6 is disabled
Date: Wed, 3 Jun 2020 21:03:44 +0800 [thread overview]
Message-ID: <202006032021.lLeRTjhD%lkp@intel.com> (raw)
In-Reply-To: <20200603103317.653-1-vinay.yadav@chelsio.com>
[-- Attachment #1: Type: text/plain, Size: 3257 bytes --]
Hi Vinay,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/Vinay-Kumar-Yadav/crypto-chtls-Fix-compile-error-when-CONFIG_IPV6-is-disabled/20200603-184315
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 065fcfd49763ec71ae345bb5c5a74f961031e70e
config: arc-allyesconfig (attached as .config)
compiler: arc-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
drivers/crypto/chelsio/chtls/chtls_cm.c: In function 'chtls_find_netdev':
>> drivers/crypto/chelsio/chtls/chtls_cm.c:105:3: error: a label can only be part of a statement and a declaration is not a statement
105 | struct net_device *temp;
| ^~~~~~
>> drivers/crypto/chelsio/chtls/chtls_cm.c:106:3: error: expected expression before 'int'
106 | int addr_type;
| ^~~
>> drivers/crypto/chelsio/chtls/chtls_cm.c:108:3: error: 'addr_type' undeclared (first use in this function); did you mean 'iter_type'?
108 | addr_type = ipv6_addr_type(&sk->sk_v6_rcv_saddr);
| ^~~~~~~~~
| iter_type
drivers/crypto/chelsio/chtls/chtls_cm.c:108:3: note: each undeclared identifier is reported only once for each function it appears in
In file included from drivers/crypto/chelsio/chtls/chtls.h:31,
from drivers/crypto/chelsio/chtls/chtls_cm.c:32:
At top level:
drivers/crypto/chelsio/chcr_algo.h:392:17: warning: 'sgl_lengths' defined but not used [-Wunused-const-variable=]
392 | static const u8 sgl_lengths[20] = {
| ^~~~~~~~~~~
vim +105 drivers/crypto/chelsio/chtls/chtls_cm.c
91
92 static struct net_device *chtls_find_netdev(struct chtls_dev *cdev,
93 struct sock *sk)
94 {
95 struct net_device *ndev = cdev->ports[0];
96
97 switch (sk->sk_family) {
98 case PF_INET:
99 if (likely(!inet_sk(sk)->inet_rcv_saddr))
100 return ndev;
101 ndev = ip_dev_find(&init_net, inet_sk(sk)->inet_rcv_saddr);
102 break;
103 #if IS_ENABLED(CONFIG_IPV6)
104 case PF_INET6:
> 105 struct net_device *temp;
> 106 int addr_type;
107
> 108 addr_type = ipv6_addr_type(&sk->sk_v6_rcv_saddr);
109 if (likely(addr_type == IPV6_ADDR_ANY))
110 return ndev;
111
112 for_each_netdev_rcu(&init_net, temp) {
113 if (ipv6_chk_addr(&init_net, (struct in6_addr *)
114 &sk->sk_v6_rcv_saddr, temp, 1)) {
115 ndev = temp;
116 break;
117 }
118 }
119 break;
120 #endif
121 default:
122 return NULL;
123 }
124
125 if (!ndev)
126 return NULL;
127
128 if (is_vlan_dev(ndev))
129 return vlan_dev_real_dev(ndev);
130 return ndev;
131 }
132
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 63063 bytes --]
next prev parent reply other threads:[~2020-06-03 13:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 10:33 [PATCH net-next] crypto/chtls: Fix compile error when CONFIG_IPV6 is disabled Vinay Kumar Yadav
2020-06-03 13:03 ` kernel test robot [this message]
2020-06-03 14:11 ` kernel test robot
2020-06-03 17:46 ` David Miller
2020-06-04 3:28 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006032021.lLeRTjhD%lkp@intel.com \
--to=lkp@intel.com \
--cc=borisp@mellanox.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=secdev@chelsio.com \
--cc=vinay.yadav@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).