netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: valentin@longchamp.me
Cc: netdev@vger.kernel.org, jiri@resnulli.us,
	xiyou.wangcong@gmail.com, jhs@mojatatu.com
Subject: Re: [PATCH] net: sched: make the watchdog functions more coherent
Date: Thu, 04 Jun 2020 15:55:12 -0700 (PDT)	[thread overview]
Message-ID: <20200604.155512.1355727491425437227.davem@davemloft.net> (raw)
In-Reply-To: <20200603212113.11801-1-valentin@longchamp.me>

From: Valentin Longchamp <valentin@longchamp.me>
Date: Wed,  3 Jun 2020 23:21:13 +0200

> Remove dev_watchdog_up() that directly called __netdev_watchdog_up() and
> rename dev_watchdog_down() to __netdev_watchdog_down() for symmetry.
> 
> Signed-off-by: Valentin Longchamp <valentin@longchamp.me>
> ---
>  net/sched/sch_generic.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
> index 2efd5b61acef..f3cb740a2941 100644
> --- a/net/sched/sch_generic.c
> +++ b/net/sched/sch_generic.c
> @@ -465,12 +465,7 @@ void __netdev_watchdog_up(struct net_device *dev)
>  	}
>  }
>  
> -static void dev_watchdog_up(struct net_device *dev)
> -{
> -	__netdev_watchdog_up(dev);
> -}
> -
> -static void dev_watchdog_down(struct net_device *dev)
> +static void __netdev_watchdog_down(struct net_device *dev)

This patch will not apply if I apply your symbol export patch because
the context above this function will be different.

Please don't do this.

  reply	other threads:[~2020-06-04 22:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-03 21:21 [PATCH] net: sched: make the watchdog functions more coherent Valentin Longchamp
2020-06-04 22:55 ` David Miller [this message]
2020-06-05  4:52   ` Valentin Longchamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200604.155512.1355727491425437227.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=valentin@longchamp.me \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).