From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Gpgn=7R=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,
	SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id E571AC433E1
	for <netdev@archiver.kernel.org>; Thu,  4 Jun 2020 10:34:21 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id BB6AF207D3
	for <netdev@archiver.kernel.org>; Thu,  4 Jun 2020 10:34:21 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1591266861;
	bh=rjZlYPQX8+7WuJlTYc7K8S4AaWWC63MoQ5lnQqgQ0Uc=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From;
	b=IlJWNeFzE22QlMZg028lsylvZNOPI25tCXLELow31p1sL5Z23x6mhb+DtzWxVhcyl
	 SMhnO15OnXoYPC3wq5PgnJ8Wn0upU5iTGvkGG/ded3XsUfQOjQmB9MYcm2fpditYtY
	 xmaZsAnmTaD/B96g8FvLUgNF8G5apeo0dvHVhsNs=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726210AbgFDKeU (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Thu, 4 Jun 2020 06:34:20 -0400
Received: from mail.kernel.org ([198.145.29.99]:36528 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725601AbgFDKeU (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 4 Jun 2020 06:34:20 -0400
Received: from localhost (unknown [213.57.247.131])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 2436B206C3;
        Thu,  4 Jun 2020 10:34:18 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1591266859;
        bh=rjZlYPQX8+7WuJlTYc7K8S4AaWWC63MoQ5lnQqgQ0Uc=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=ADsvpQbM0IbvLDKQtUXimWcx0vuht5cCwa9xpPJNU1y2muJb/f6lTtGmaAsSAipob
         EN0ojuuLT+Yb/x3ia9bPxxDQcp0/gcTvYT0rEfYikwQbVuD6OmVQPuxQHFWpEDH9dp
         1wiKkgOVjQ0VwG1YQzIYy7Xoh1drl3WsBJFQv1pw=
Date:   Thu, 4 Jun 2020 13:34:16 +0300
From:   Leon Romanovsky <leon@kernel.org>
To:     Matthew Wilcox <willy@infradead.org>
Cc:     linux-rdma@vger.kernel.org, Paul Blakey <paulb@mellanox.com>,
        Saeed Mahameed <saeedm@mellanox.com>,
        linux-netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] net/mlx5: Improve tuple ID allocation
Message-ID: <20200604103416.GB8834@unreal>
References: <20200603152901.17985-1-willy@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200603152901.17985-1-willy@infradead.org>
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Wed, Jun 03, 2020 at 08:29:01AM -0700, Matthew Wilcox wrote:
> From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
>
> There's no need to use a temporary variable; the XArray is designed to
> write directly into the object being allocated.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
t

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>