From: David Miller <davem@davemloft.net>
To: palok@marvell.com
Cc: netdev@vger.kernel.org, bhsharma@redhat.com, irusskikh@marvell.com
Subject: Re: [PATCH] net: qed: fixes crash while running driver in kdump kernel
Date: Fri, 05 Jun 2020 13:20:58 -0700 (PDT) [thread overview]
Message-ID: <20200605.132058.751437025187060374.davem@davemloft.net> (raw)
In-Reply-To: <20200605163034.26879-1-palok@marvell.com>
From: Alok Prasad <palok@marvell.com>
Date: Fri, 5 Jun 2020 16:30:34 +0000
> This fixes a crash introduced by recent is_kdump_kernel() check.
> The source of the crash is that kdump kernel can be loaded on a
> system with already created VFs. But for such VFs, it will follow
> a logic path of PF and eventually crash.
>
> Thus, we are partially reverting back previous changes and instead
> use is_kdump_kernel is a single init point of PF init, where we
> disable SRIOV explicitly.
>
> Fixes: 37d4f8a6b41f ("net: qed: Disable SRIOV functionality inside kdump kernel")
> Cc: Bhupesh Sharma <bhsharma@redhat.com>
> Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
> Signed-off-by: Alok Prasad <palok@marvell.com>
Applied.
prev parent reply other threads:[~2020-06-05 20:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 16:30 [PATCH] net: qed: fixes crash while running driver in kdump kernel Alok Prasad
2020-06-05 20:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200605.132058.751437025187060374.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhsharma@redhat.com \
--cc=irusskikh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=palok@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).