From: Kees Cook <keescook@chromium.org>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
stephen@networkplumber.org, o.rempel@pengutronix.de,
andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com,
kuba@kernel.org, corbet@lwn.net, linville@tuxdriver.com,
david@protonic.nl, kernel@pengutronix.de,
linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
mkl@pengutronix.de, marex@denx.de, christian.herber@nxp.com,
amitc@mellanox.com, petrm@mellanox.com
Subject: Re: [PATCH ethtool v1] netlink: add master/slave configuration support
Date: Tue, 9 Jun 2020 14:34:33 -0700 [thread overview]
Message-ID: <202006091358.6FD35CF@keescook> (raw)
In-Reply-To: <20200609205303.z3kfoptj7w2jpnts@lion.mk-sys.cz>
On Tue, Jun 09, 2020 at 10:53:03PM +0200, Michal Kubecek wrote:
> The same IMHO holds for your example with register states or names:
> I believe it is highly beneficial to make them consistent with technical
> documentation. There are even cases where we violate kernel coding style
> (e.g. by using camelcase) to match the names from specification.
Yup, when I saw the original patch it wasn't clear this was matching a
spec. I haven't been arguing for the $subject patch since Dave pointed
that out, and am now trying to shape what the general guidance should
be.
--
Kees Cook
next prev parent reply other threads:[~2020-06-09 21:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 9:10 [PATCH ethtool v1] netlink: add master/slave configuration support Oleksij Rempel
2020-05-26 12:41 ` Michal Kubecek
2020-05-27 10:26 ` Oleksij Rempel
2020-06-07 22:30 ` Stephen Hemminger
2020-06-07 23:45 ` David Miller
2020-06-09 17:19 ` Stephen Hemminger
2020-06-09 18:30 ` Andrew Lunn
2020-06-09 18:36 ` David Miller
2020-06-09 19:29 ` Kees Cook
2020-06-09 19:34 ` David Miller
2020-06-09 19:49 ` Kees Cook
2020-06-09 20:05 ` David Miller
2020-06-09 20:29 ` Kees Cook
2020-06-09 20:53 ` Michal Kubecek
2020-06-09 21:34 ` Kees Cook [this message]
2020-06-09 19:30 ` Williams, Dan J
2020-06-09 19:38 ` David Miller
2020-06-09 21:48 ` Dan Williams
2020-06-10 6:07 ` Oleksij Rempel
2020-06-09 18:46 ` Edward Cree
2020-06-09 20:31 ` Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006091358.6FD35CF@keescook \
--to=keescook@chromium.org \
--cc=amitc@mellanox.com \
--cc=andrew@lunn.ch \
--cc=christian.herber@nxp.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=david@protonic.nl \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linville@tuxdriver.com \
--cc=marex@denx.de \
--cc=mkl@pengutronix.de \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=petrm@mellanox.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).