From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=f+5y=AE=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id CDBA2C433E0
	for <netdev@archiver.kernel.org>; Tue, 23 Jun 2020 21:04:14 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 95C242070E
	for <netdev@archiver.kernel.org>; Tue, 23 Jun 2020 21:04:14 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1592946254;
	bh=jJIW+p9OyYiiw56Z+mZUA5cdxbphGvJCpK8z8PNr4ts=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From;
	b=pQGOAxxQOlJ2+VMv3hhYKOnYzXCd/mnnwZW6Pe5A2k362gb31GvpJwNO+E1NNamiM
	 pc8EKkvsFoxT5D3BwfB7Y4zsTJiNEk5pqQ7aZiH/TGSmLHLthv+z4i/m1/ZWli0HSE
	 aF1fI8Hc+gGF/T9w4upMTXm/bFgMkhJJpqdOaG/U=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2392886AbgFWVEF (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Tue, 23 Jun 2020 17:04:05 -0400
Received: from mail.kernel.org ([198.145.29.99]:34796 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S2389620AbgFWVD7 (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 23 Jun 2020 17:03:59 -0400
Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.6])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 3E72420724;
        Tue, 23 Jun 2020 21:03:59 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1592946239;
        bh=jJIW+p9OyYiiw56Z+mZUA5cdxbphGvJCpK8z8PNr4ts=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=xjrvCOXQces/UtDKEssR4iHIvOmXtcz4B+mvwkFnOcM2nmWSFgS0j6W0kc0NJKJ/Z
         ceWUGFbW9RJfK12drdF3Mi86E6x4GwIPasqJlyT8TPix1g1lha6SNGfnSeAYpPsJze
         +2BJLHgkRe/J7AApN/GJE4Ipx7gRGf953ZZR6UUg=
Date:   Tue, 23 Jun 2020 14:03:57 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Saeed Mahameed <saeedm@mellanox.com>
Cc:     "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        Vlad Buslov <vladbu@mellanox.com>,
        Roi Dayan <roid@mellanox.com>,
        Maor Dickman <maord@mellanox.com>
Subject: Re: [net-next 07/10] net/mlx5e: Move TC-specific function
 definitions into MLX5_CLS_ACT
Message-ID: <20200623140357.6412f74f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20200623195229.26411-8-saeedm@mellanox.com>
References: <20200623195229.26411-1-saeedm@mellanox.com>
 <20200623195229.26411-8-saeedm@mellanox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Tue, 23 Jun 2020 12:52:26 -0700 Saeed Mahameed wrote:
> From: Vlad Buslov <vladbu@mellanox.com>
> 
> en_tc.h header file declares several TC-specific functions in
> CONFIG_MLX5_ESWITCH block even though those functions are only compiled
> when CONFIG_MLX5_CLS_ACT is set, which is a recent change. Move them to
> proper block.
> 
> Fixes: d956873f908c ("net/mlx5e: Introduce kconfig var for TC support")

and here... do those break build or something?

> Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
> Reviewed-by: Roi Dayan <roid@mellanox.com>
> Reviewed-by: Maor Dickman <maord@mellanox.com>
> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>