From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACFFDC433E0 for ; Tue, 23 Jun 2020 21:33:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8934020724 for ; Tue, 23 Jun 2020 21:33:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592948012; bh=9NLg7n4Vm8YuhO5SLAOq3ATmcJRnYMPf7/udDDBSDBI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=osvT9dPF28fmMfpJD+BwTa01vcL+zmPHdGX2IzIUaT6zm/VKnhSSvYK6f9OqRcVai u3ygiCW5AwO1PRtmLG/cd9xp/wguBVi7zZlQGZioU2Eu884CGbfYxdIrymBgcRqr8e 7mWWGLwX4knccpd4KwibVH56xHWhg3ueiK1S+AEA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393698AbgFWVdb (ORCPT ); Tue, 23 Jun 2020 17:33:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:53784 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390399AbgFWVd3 (ORCPT ); Tue, 23 Jun 2020 17:33:29 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9A02A20707; Tue, 23 Jun 2020 21:33:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592948008; bh=9NLg7n4Vm8YuhO5SLAOq3ATmcJRnYMPf7/udDDBSDBI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oDugkRISYUgLWN+1xRK+0FTsRkEAV0LvwNxhHM9AYpGCR+lJfNksI8qQxuWyhM7XC GiLIYevffhXhHLX3TaI9BSUOCrIbxh/URf2ZjsCJJbWukrjjLz5YUj6qcBIp3G1Wka LpYyVxsA1X+hBPa6DTVv9XoEi+uZMZU4OX6i3gPs= Date: Tue, 23 Jun 2020 14:33:27 -0700 From: Jakub Kicinski To: Saeed Mahameed Cc: Roi Dayan , Maor Dickman , "davem@davemloft.net" , "netdev@vger.kernel.org" , Vlad Buslov Subject: Re: [net-next 07/10] net/mlx5e: Move TC-specific function definitions into MLX5_CLS_ACT Message-ID: <20200623143327.473a1d88@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <3e259566a57c6ce50843c1fadd80530e3307bc62.camel@mellanox.com> References: <20200623195229.26411-1-saeedm@mellanox.com> <20200623195229.26411-8-saeedm@mellanox.com> <20200623140357.6412f74f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <3e259566a57c6ce50843c1fadd80530e3307bc62.camel@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 23 Jun 2020 21:26:02 +0000 Saeed Mahameed wrote: > On Tue, 2020-06-23 at 14:03 -0700, Jakub Kicinski wrote: > > On Tue, 23 Jun 2020 12:52:26 -0700 Saeed Mahameed wrote: > > > From: Vlad Buslov > > > > > > en_tc.h header file declares several TC-specific functions in > > > CONFIG_MLX5_ESWITCH block even though those functions are only > > > compiled > > > when CONFIG_MLX5_CLS_ACT is set, which is a recent change. Move > > > them to > > > proper block. > > > > > > Fixes: d956873f908c ("net/mlx5e: Introduce kconfig var for TC > > > support") > > > > and here... do those break build or something? > > No, just redundant exposure and leftovers. > Do you want me to remove the Fixes Tags ? > Personally I don't mind fixes tags for something this basic, > but your call.. If you don't mind - please remove them, IMHO frivolous use of Fixes tags removes half of their value.