From: David Miller <davem@davemloft.net>
To: tobias@waldekranz.com
Cc: netdev@vger.kernel.org, fugang.duan@nxp.com
Subject: Re: [PATCH net] net: ethernet: fec: prevent tx starvation under high rx load
Date: Tue, 30 Jun 2020 12:58:02 -0700 (PDT) [thread overview]
Message-ID: <20200630.125802.533305649716945637.davem@davemloft.net> (raw)
In-Reply-To: <C3U8BLV1WZ9R.1SDRQTA6XXRPB@wkz-x280>
From: "Tobias Waldekranz" <tobias@waldekranz.com>
Date: Tue, 30 Jun 2020 08:39:58 +0200
> On Mon Jun 29, 2020 at 3:07 PM CEST, David Miller wrote:
>> I don't see how this can happen since you process the TX queue
>> unconditionally every NAPI pass, regardless of what bits you see
>> set in the IEVENT register.
>>
>> Or don't you? Oh, I see, you don't:
>>
>> for_each_set_bit(queue_id, &fep->work_tx, FEC_ENET_MAX_TX_QS) {
>>
>> That's the problem. Just unconditionally process the TX work regardless
>> of what is in IEVENT. That whole ->tx_work member and the code that
>> uses it can just be deleted. fec_enet_collect_events() can just return
>> a boolean saying whether there is any RX or TX work at all.
>
> Maybe Andy could chime in here, but I think the ->tx_work construction
> is load bearing. It seems to me like that is the only thing stopping
> us from trying to process non-existing queues on older versions of the
> silicon which only has a single queue.
Then iterate over "actually existing" queues.
My primary point still stands.
next prev parent reply other threads:[~2020-06-30 19:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 19:16 [PATCH net] net: ethernet: fec: prevent tx starvation under high rx load Tobias Waldekranz
2020-06-29 20:07 ` David Miller
2020-06-30 6:39 ` Tobias Waldekranz
2020-06-30 19:58 ` David Miller [this message]
2020-07-01 3:22 ` [EXT] " Andy Duan
2020-06-30 6:28 ` [EXT] " Andy Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630.125802.533305649716945637.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fugang.duan@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=tobias@waldekranz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).