netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: bjorn.andersson@linaro.org, manivannan.sadhasivam@linaro.org,
	kuba@kernel.org, wenhu.wang@vivo.com, wgong@codeaurora.org,
	cjhuang@codeaurora.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH net] net: qrtr: Fix an out of bounds read qrtr_endpoint_post()
Date: Tue, 30 Jun 2020 18:36:58 -0700 (PDT)	[thread overview]
Message-ID: <20200630.183658.1733479085086002611.davem@davemloft.net> (raw)
In-Reply-To: <20200630114615.GA21891@mwanda>

From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 30 Jun 2020 14:46:15 +0300

> This code assumes that the user passed in enough data for a
> qrtr_hdr_v1 or qrtr_hdr_v2 struct, but it's not necessarily true.  If
> the buffer is too small then it will read beyond the end.
> 
> Reported-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Reported-by: syzbot+b8fe393f999a291a9ea6@syzkaller.appspotmail.com
> Fixes: 194ccc88297a ("net: qrtr: Support decoding incoming v2 packets")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied and queued up for -stable, thanks Dan.

      reply	other threads:[~2020-07-01  1:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-27  8:50 KASAN: slab-out-of-bounds Read in qrtr_endpoint_post syzbot
2020-06-27 20:57 ` syzbot
2020-06-28 10:46   ` Manivannan Sadhasivam
2020-06-30 11:46     ` [PATCH net] net: qrtr: Fix an out of bounds read qrtr_endpoint_post() Dan Carpenter
2020-07-01  1:36       ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200630.183658.1733479085086002611.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bjorn.andersson@linaro.org \
    --cc=cjhuang@codeaurora.org \
    --cc=dan.carpenter@oracle.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=wenhu.wang@vivo.com \
    --cc=wgong@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).