From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87E50C433DF for ; Tue, 30 Jun 2020 16:26:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5270320722 for ; Tue, 30 Jun 2020 16:26:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593534408; bh=LepBiuzFP0vqeERpZtYouE+9jvZcJiHHMFzk8JoxjZY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=bRxIvQvz8Z25k0VZwfW/oMYj+bXzlG/y/Oij/nJzibjAzfnaan8DyBnSRKKgkGbG7 LNz1QYWRNuIQ0h2qZ/sYbbhOAufZSpAMNgM/nRO6sgXLnMfSiFQm3wiK9ktOUgkhVB JPEw9K8vBTSnh5lT5mAt/zsqqAmQZMqEVZGPY6AM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387820AbgF3Q0r (ORCPT ); Tue, 30 Jun 2020 12:26:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:45256 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387434AbgF3Q0q (ORCPT ); Tue, 30 Jun 2020 12:26:46 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 61B94206BE; Tue, 30 Jun 2020 16:26:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593534406; bh=LepBiuzFP0vqeERpZtYouE+9jvZcJiHHMFzk8JoxjZY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=H4kVkmdgvimCpEsoWFiYQLEX9kBEvIIawPSPqj8xGeenuGg6swrDykmI/6cV9FPCr oN2+ZbOAVZxWaz9Cg9qOJXhfLgCYEPH3Jd8mkcWNzhL4NQz40KZfEe53l4PM4v2Bmt VJ2qph6JI++N/4wt63JfP9EtIyGgY5y5/8DAsmEQ= Date: Tue, 30 Jun 2020 09:26:44 -0700 From: Jakub Kicinski To: Yousuk Seung Cc: David Miller , netdev@vger.kernel.org, Willem de Bruijn , Eric Dumazet , Soheil Hassas Yeganeh Subject: Re: [PATCH net-next] tcp: call tcp_ack_tstamp() when not fully acked Message-ID: <20200630092644.131af53c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200630020132.2332374-1-ysseung@google.com> References: <20200630020132.2332374-1-ysseung@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 29 Jun 2020 19:01:32 -0700 Yousuk Seung wrote: > When skb is coalesced tcp_ack_tstamp() still needs to be called when not > fully acked in tcp_clean_rtx_queue(), otherwise SCM_TSTAMP_ACK > timestamps may never be fired. Since the original patch series had > dependent commits, this patch fixes the issue instead of reverting by > restoring calls to tcp_ack_tstamp() when skb is not fully acked. > > Fixes: fdb7eb21ddd3 ("tcp: stamp SCM_TSTAMP_ACK later in tcp_clean_rtx_queue()) > Signed-off-by: Yousuk Seung > Signed-off-by: Willem de Bruijn > Signed-off-by: Eric Dumazet > Acked-by: Soheil Hassas Yeganeh Fixes tag: Fixes: fdb7eb21ddd3 ("tcp: stamp SCM_TSTAMP_ACK later in tcp_clean_rtx_queue()) Has these problem(s): - Subject has leading but no trailing quotes