From: David Miller <davem@davemloft.net>
To: claudiu.beznea@microchip.com
Cc: nicolas.ferre@microchip.com, kuba@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/4] net: macb: use hweight_long() to count set bits in queue_mask
Date: Wed, 01 Jul 2020 12:22:41 -0700 (PDT) [thread overview]
Message-ID: <20200701.122241.894076396008620124.davem@davemloft.net> (raw)
In-Reply-To: <1593608931-3718-3-git-send-email-claudiu.beznea@microchip.com>
From: Claudiu Beznea <claudiu.beznea@microchip.com>
Date: Wed, 1 Jul 2020 16:08:49 +0300
> @@ -3482,8 +3482,6 @@ static void macb_probe_queues(void __iomem *mem,
> unsigned int *queue_mask,
...
> + *num_queues = hweight_long(*queue_mask);
queue_mask is not a long, it is an unsinged int, therefore hweight32() is
probably more appropriate.
next prev parent reply other threads:[~2020-07-01 19:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 13:08 [PATCH net-next 0/4] net: macb: few code cleanups Claudiu Beznea
2020-07-01 13:08 ` [PATCH net-next 1/4] net: macb: do not set again bit 0 of queue_mask Claudiu Beznea
2020-07-01 13:08 ` [PATCH net-next 2/4] net: macb: use hweight_long() to count set bits in queue_mask Claudiu Beznea
2020-07-01 19:22 ` David Miller [this message]
2020-07-01 13:08 ` [PATCH net-next 3/4] net: macb: do not initialize queue variable Claudiu Beznea
2020-07-01 13:08 ` [PATCH net-next 4/4] net: macb: remove is_udp variable Claudiu Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701.122241.894076396008620124.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=claudiu.beznea@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).