From: "Björn Töpel" <bjorn.topel@gmail.com>
To: intel-wired-lan@lists.osuosl.org
Cc: "Björn Töpel" <bjorn.topel@intel.com>,
magnus.karlsson@intel.com, netdev@vger.kernel.org,
bpf@vger.kernel.org
Subject: [PATCH net-next 3/4] i40e, xsk: increase budget for AF_XDP path
Date: Thu, 2 Jul 2020 17:37:29 +0200 [thread overview]
Message-ID: <20200702153730.575738-4-bjorn.topel@gmail.com> (raw)
In-Reply-To: <20200702153730.575738-1-bjorn.topel@gmail.com>
From: Björn Töpel <bjorn.topel@intel.com>
The napi_budget, meaning the number of received packets that are
allowed to be processed for each napi invocation, takes into
consideration that each received packet is aimed for the kernel
networking stack.
That is not the case for the AF_XDP receive path, where the cost of
each packet is significantly less. Therefore, this commit disregards
the napi budget and increases it to 256. Processing 256 packets
targeted for AF_XDP is still less work than 64 (napi budget) packets
going to the kernel networking stack.
The performance for the rx_drop scenario is up 7%.
Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_xsk.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
index 1f2dd591dbf1..99f4afdc403d 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
@@ -265,6 +265,8 @@ static void i40e_inc_ntc(struct i40e_ring *rx_ring)
rx_ring->next_to_clean = ntc;
}
+#define I40E_XSK_CLEAN_RX_BUDGET 256U
+
/**
* i40e_clean_rx_irq_zc - Consumes Rx packets from the hardware ring
* @rx_ring: Rx ring
@@ -280,7 +282,7 @@ int i40e_clean_rx_irq_zc(struct i40e_ring *rx_ring, int budget)
bool failure = false;
struct sk_buff *skb;
- while (likely(total_rx_packets < (unsigned int)budget)) {
+ while (likely(total_rx_packets < I40E_XSK_CLEAN_RX_BUDGET)) {
union i40e_rx_desc *rx_desc;
struct xdp_buff **bi;
unsigned int size;
--
2.25.1
next prev parent reply other threads:[~2020-07-02 15:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 15:37 [PATCH net-next 0/4] i40e driver performance tweaks for AF_XDP Björn Töpel
2020-07-02 15:37 ` [PATCH net-next 1/4] i40e, xsk: remove HW descriptor prefetch in AF_XDP path Björn Töpel
2020-07-08 20:43 ` [Intel-wired-lan] " Bowers, AndrewX
2020-07-02 15:37 ` [PATCH net-next 2/4] i40e: use 16B HW descriptors instead of 32B Björn Töpel
2020-07-08 20:43 ` [Intel-wired-lan] " Bowers, AndrewX
2020-07-02 15:37 ` Björn Töpel [this message]
2020-07-08 20:44 ` [Intel-wired-lan] [PATCH net-next 3/4] i40e, xsk: increase budget for AF_XDP path Bowers, AndrewX
2020-07-02 15:37 ` [PATCH net-next 4/4] i40e, xsk: move buffer allocation out of the Rx processing loop Björn Töpel
2020-07-08 20:45 ` [Intel-wired-lan] " Bowers, AndrewX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702153730.575738-4-bjorn.topel@gmail.com \
--to=bjorn.topel@gmail.com \
--cc=bjorn.topel@intel.com \
--cc=bpf@vger.kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).