From: kernel test robot <lkp@intel.com>
To: izabela.bakollari@gmail.com, nhorman@tuxdriver.com,
davem@davemloft.net, kuba@kernel.org
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
izabela.bakollari@gmail.com
Subject: Re: [PATCH net-next] dropwatch: Support monitoring of dropped frames
Date: Wed, 8 Jul 2020 08:27:15 +0800 [thread overview]
Message-ID: <202007080847.UtlXhrMq%lkp@intel.com> (raw)
In-Reply-To: <20200707171515.110818-1-izabela.bakollari@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3358 bytes --]
Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/izabela-bakollari-gmail-com/dropwatch-Support-monitoring-of-dropped-frames/20200708-011806
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git d47a72152097d7be7cfc453d205196c0aa976c33
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 02946de3802d3bc65bc9f2eb9b8d4969b5a7add8)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
>> net/core/drop_monitor.c:226:21: warning: variable 'data' is uninitialized when used here [-Wuninitialized]
spin_lock_irqsave(&data->lock, flags);
^~~~
include/linux/spinlock.h:383:39: note: expanded from macro 'spin_lock_irqsave'
raw_spin_lock_irqsave(spinlock_check(lock), flags); \
^~~~
include/linux/spinlock.h:251:34: note: expanded from macro 'raw_spin_lock_irqsave'
flags = _raw_spin_lock_irqsave(lock); \
^~~~
net/core/drop_monitor.c:223:30: note: initialize the variable 'data' to silence this warning
struct per_cpu_dm_data *data;
^
= NULL
>> net/core/drop_monitor.c:1375:47: error: no member named 'ifname' in 'struct net_device'; did you mean 'name'?
rc = net_dm_interface_stop(net, interface->ifname);
^~~~~~
name
include/linux/netdevice.h:1844:9: note: 'name' declared here
char name[IFNAMSIZ];
^
1 warning and 1 error generated.
vim +1375 net/core/drop_monitor.c
1357
1358 static int net_dm_cmd_ifc_trace(struct sk_buff *skb, struct genl_info *info)
1359 {
1360 struct net *net = sock_net(skb->sk);
1361 char ifname[IFNAMSIZ];
1362 int rc;
1363
1364 memset(ifname, 0, IFNAMSIZ);
1365 nla_strlcpy(ifname, info->attrs[NET_DM_ATTR_IFNAME], IFNAMSIZ - 1);
1366
1367 switch (info->genlhdr->cmd) {
1368 case NET_DM_CMD_START_IFC:
1369 rc = net_dm_interface_start(net, ifname);
1370 if (rc)
1371 return rc;
1372 break;
1373 case NET_DM_CMD_STOP_IFC:
1374 if (interface) {
> 1375 rc = net_dm_interface_stop(net, interface->ifname);
1376 return rc;
1377 } else {
1378 return -ENODEV;
1379 }
1380 }
1381
1382 return 0;
1383 }
1384
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 75310 bytes --]
next prev parent reply other threads:[~2020-07-08 0:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 17:15 [PATCH net-next] dropwatch: Support monitoring of dropped frames izabela.bakollari
2020-07-07 17:33 ` Eric Dumazet
2020-07-07 17:36 ` Eric Dumazet
2020-07-07 17:52 ` Eric Dumazet
2020-07-08 14:06 ` Izabela Bakollari
2020-07-07 21:00 ` kernel test robot
2020-07-08 0:27 ` kernel test robot [this message]
2020-08-04 16:09 ` [PATCHv2 " izabela.bakollari
2020-08-04 21:28 ` Cong Wang
2020-08-04 21:58 ` [Linux-kernel-mentees] " Neil Horman
2020-08-04 23:14 ` David Miller
2020-08-05 10:44 ` Neil Horman
2020-08-10 13:39 ` Izabela Bakollari
2020-08-10 13:56 ` [Linux-kernel-mentees] " Greg KH
2020-08-31 13:18 ` Michal Schmidt
2020-09-02 16:05 ` Izabela Bakollari
2020-09-02 17:16 ` [PATCHv3 " izabela.bakollari
2020-09-02 20:35 ` Eric Dumazet
2020-10-23 4:29 ` [PATCHv4 " izabela.bakollari
2020-10-23 18:20 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202007080847.UtlXhrMq%lkp@intel.com \
--to=lkp@intel.com \
--cc=clang-built-linux@googlegroups.com \
--cc=davem@davemloft.net \
--cc=izabela.bakollari@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).