From: Jakub Kicinski <kuba@kernel.org>
To: "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
Cc: "Wang, Haiyue" <haiyue.wang@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"Zhang, Xiao" <xiao.zhang@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Venkataramanan, Anirudh" <anirudh.venkataramanan@intel.com>
Subject: Re: [Intel-wired-lan] [net-next, v7 5/5] ice: add switch rule management for DCF
Date: Wed, 8 Jul 2020 16:48:12 -0700 [thread overview]
Message-ID: <20200708164812.384ae8ea@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <eca3253391dd34a267e607dbd847d6878bc3a6fe.camel@intel.com>
On Wed, 8 Jul 2020 22:55:21 +0000 Nguyen, Anthony L wrote:
> > @@ -490,7 +476,7 @@ ice_aq_alloc_free_vsi_list(struct ice_hw *hw, u16
> > *vsi_list_id,
> > *
> > * Add(0x02a0)/Update(0x02a1)/Remove(0x02a2) switch rules commands
> > to firmware
> > */
> > -static enum ice_status
> > +enum ice_status
> > ice_aq_sw_rules(struct ice_hw *hw, void *rule_list, u16
> > rule_list_sz,
> > u8 num_rules, enum ice_adminq_opc opc, struct ice_sq_cd
> > *cd)
> > {
>
> Hi Dave, Jakub,
>
> This feature is only built when CONFIG_PCI_IOV is set. We end up with
> this namespace issue using defconfig when checked against namespace.pl
> since CONFIG_PCI_IOV is not enabled.
> Externally defined symbols with no external references
> ice_switch.o
> ice_aq_sw_rules
>
> From a previous patch, neither of you liked the use of CONFIG_ to
> control static-ness. I wanted to check that you are ok with the
> namespace issue or if you have a preferred method to resolve this
> issue. I appreciate your feedback.
IMHO that should be fine. I'd only trust namespace.pl on a all*config
kernel, if at all.
prev parent reply other threads:[~2020-07-08 23:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200619045711.16055-1-haiyue.wang@intel.com>
[not found] ` <20200701012557.40234-1-haiyue.wang@intel.com>
[not found] ` <20200701012557.40234-6-haiyue.wang@intel.com>
2020-07-08 22:55 ` [Intel-wired-lan] [net-next, v7 5/5] ice: add switch rule management for DCF Nguyen, Anthony L
2020-07-08 23:48 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708164812.384ae8ea@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=anirudh.venkataramanan@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=beilei.xing@intel.com \
--cc=davem@davemloft.net \
--cc=haiyue.wang@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=xiao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).