From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-bluetooth <linux-bluetooth@vger.kernel.org>,
kernel list <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH][next] Bluetooth: Use fallthrough pseudo-keyword
Date: Wed, 8 Jul 2020 13:32:15 -0500 [thread overview]
Message-ID: <20200708183215.GI11533@embeddedor> (raw)
In-Reply-To: <AA68478E-A46A-4914-BE62-3AC9989E358D@holtmann.org>
On Wed, Jul 08, 2020 at 06:49:39AM +0200, Marcel Holtmann wrote:
> Hi Gustavo,
>
> > Replace the existing /* fall through */ comments and its variants with
> > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
> > fall-through markings when it is the case.
> >
> > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
> >
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> > ---
> > drivers/bluetooth/bcm203x.c | 2 +-
> > drivers/bluetooth/bluecard_cs.c | 2 --
> > drivers/bluetooth/hci_ll.c | 2 +-
> > drivers/bluetooth/hci_qca.c | 8 +-------
> > net/bluetooth/hci_event.c | 4 ++--
> > net/bluetooth/hci_sock.c | 3 +--
> > net/bluetooth/l2cap_core.c | 19 +++++++++----------
> > net/bluetooth/l2cap_sock.c | 4 ++--
> > net/bluetooth/mgmt.c | 4 ++--
> > net/bluetooth/rfcomm/core.c | 2 +-
> > net/bluetooth/rfcomm/sock.c | 2 +-
> > net/bluetooth/smp.c | 2 +-
> > 12 files changed, 22 insertions(+), 32 deletions(-)
>
> can we split these a little bit between drivers, core and rfcomm. Thanks.
>
Sure thing, no problem. I'll split this up and send again.
Thanks
--
Gustavo
prev parent reply other threads:[~2020-07-08 18:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 20:35 [PATCH][next] Bluetooth: Use fallthrough pseudo-keyword Gustavo A. R. Silva
2020-07-08 4:49 ` Marcel Holtmann
2020-07-08 18:32 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708183215.GI11533@embeddedor \
--to=gustavoars@kernel.org \
--cc=davem@davemloft.net \
--cc=johan.hedberg@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).