From: Nick Desaulniers <ndesaulniers@google.com>
To: "David S . Miller" <davem@davemloft.net>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>,
oss-drivers@netronome.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Alex Elder <elder@linaro.org>,
Nick Desaulniers <ndesaulniers@google.com>
Subject: [PATCH v2 0/2 net] bitfield.h cleanups
Date: Wed, 8 Jul 2020 16:04:00 -0700 [thread overview]
Message-ID: <20200708230402.1644819-1-ndesaulniers@google.com> (raw)
Two patches, one that removes a BUILD_BUG_ON for a case that is not a
compile time bug (exposed by compiler optimization).
The second is a general cleanup in the area.
I decided to leave the BUILD_BUG_ON case first, as I hope it will
simplify being able to backport it to stable, and because I don't think
there's any type promotion+conversion bugs there.
Though it would be nice to use consistent types widths and signedness,
equality against literal zero is not an issue.
Jakub Kicinski (1):
bitfield.h: don't compile-time validate _val in FIELD_FIT
Nick Desaulniers (1):
bitfield.h: split up __BF_FIELD_CHECK macro
.../netronome/nfp/nfpcore/nfp_nsp_eth.c | 11 ++++----
include/linux/bitfield.h | 26 +++++++++++++------
2 files changed, 24 insertions(+), 13 deletions(-)
--
2.27.0.383.g050319c2ae-goog
next reply other threads:[~2020-07-08 23:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 23:04 Nick Desaulniers [this message]
2020-07-08 23:04 ` [PATCH v2 1/2 net] bitfield.h: don't compile-time validate _val in FIELD_FIT Nick Desaulniers
2020-07-09 1:48 ` Alex Elder
2020-07-08 23:04 ` [PATCH v2 2/2] bitfield.h: split up __BF_FIELD_CHECK macro Nick Desaulniers
2020-07-09 2:11 ` Alex Elder
2020-07-09 2:11 ` Alex Elder
2020-07-14 18:23 ` [PATCH v2 0/2 net] bitfield.h cleanups Nick Desaulniers
2020-07-20 19:48 ` Nick Desaulniers
2020-07-20 23:34 ` David Miller
2020-07-30 22:37 ` Nick Desaulniers
2020-08-05 17:44 ` Nick Desaulniers
2020-08-06 18:13 ` Jakub Kicinski
2020-08-06 18:15 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708230402.1644819-1-ndesaulniers@google.com \
--to=ndesaulniers@google.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=elder@linaro.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).