From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: f.fainelli@gmail.com, kuba@kernel.org,
bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] net: systemport: fix double shift of a vlan_tci by VLAN_PRIO_SHIFT
Date: Thu, 09 Jul 2020 13:07:17 -0700 (PDT) [thread overview]
Message-ID: <20200709.130717.943617001507092696.davem@davemloft.net> (raw)
In-Reply-To: <20200708183723.1212652-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Wed, 8 Jul 2020 19:37:23 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently the u16 skb->vlan_tci is being right shifted twice by
> VLAN_PRIO_SHIFT, once in the macro skb_vlan_tag_get_pri and explicitly
> by VLAN_PRIO_SHIFT afterwards. The combined shift amount is larger than
> the u16 so the end result is always zero. Remove the second explicit
> shift as this is extraneous.
>
> Fixes: 6e9fdb60d362 ("net: systemport: Add support for VLAN transmit acceleration")
> Addresses-Coverity: ("Operands don't affect result")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to net-next, thanks.
prev parent reply other threads:[~2020-07-09 20:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 18:37 [PATCH][next] net: systemport: fix double shift of a vlan_tci by VLAN_PRIO_SHIFT Colin King
2020-07-08 20:32 ` Florian Fainelli
2020-07-09 20:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200709.130717.943617001507092696.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=colin.king@canonical.com \
--cc=f.fainelli@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).