From: Andrew Lunn <andrew@lunn.ch>
To: David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>, Andrew Lunn <andrew@lunn.ch>
Subject: [PATCH net-next 08/20] net: llc: kerneldoc fixes
Date: Mon, 13 Jul 2020 01:15:04 +0200 [thread overview]
Message-ID: <20200712231516.1139335-9-andrew@lunn.ch> (raw)
In-Reply-To: <20200712231516.1139335-1-andrew@lunn.ch>
Simple fixes which require no deep knowledge of the code.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
net/llc/af_llc.c | 1 -
net/llc/llc_conn.c | 7 ++++---
net/llc/llc_input.c | 1 +
net/llc/llc_pdu.c | 2 +-
net/llc/llc_sap.c | 3 +++
5 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/net/llc/af_llc.c b/net/llc/af_llc.c
index 54fb8d452a7b..a7e5d23df5e7 100644
--- a/net/llc/af_llc.c
+++ b/net/llc/af_llc.c
@@ -980,7 +980,6 @@ static int llc_ui_sendmsg(struct socket *sock, struct msghdr *msg, size_t len)
* llc_ui_getname - return the address info of a socket
* @sock: Socket to get address of.
* @uaddr: Address structure to return information.
- * @uaddrlen: Length of address structure.
* @peer: Does user want local or remote address information.
*
* Return the address information of a socket.
diff --git a/net/llc/llc_conn.c b/net/llc/llc_conn.c
index 7b620acaca9e..1144cda2a0fc 100644
--- a/net/llc/llc_conn.c
+++ b/net/llc/llc_conn.c
@@ -284,8 +284,8 @@ out:;
/**
* llc_conn_remove_acked_pdus - Removes acknowledged pdus from tx queue
* @sk: active connection
- * nr: NR
- * how_many_unacked: size of pdu_unack_q after removing acked pdus
+ * @nr: NR
+ * @how_many_unacked: size of pdu_unack_q after removing acked pdus
*
* Removes acknowledged pdus from transmit queue (pdu_unack_q). Returns
* the number of pdus that removed from queue.
@@ -906,6 +906,7 @@ static void llc_sk_init(struct sock *sk)
/**
* llc_sk_alloc - Allocates LLC sock
+ * @net: network namespace
* @family: upper layer protocol family
* @priority: for allocation (%GFP_KERNEL, %GFP_ATOMIC, etc)
*
@@ -951,7 +952,7 @@ void llc_sk_stop_all_timers(struct sock *sk, bool sync)
/**
* llc_sk_free - Frees a LLC socket
- * @sk - socket to free
+ * @sk: - socket to free
*
* Frees a LLC socket
*/
diff --git a/net/llc/llc_input.c b/net/llc/llc_input.c
index 82cb93f66b9b..c309b72a5877 100644
--- a/net/llc/llc_input.c
+++ b/net/llc/llc_input.c
@@ -144,6 +144,7 @@ static inline int llc_fixup_skb(struct sk_buff *skb)
* @skb: received pdu
* @dev: device that receive pdu
* @pt: packet type
+ * @orig_dev: the original receive net device
*
* When the system receives a 802.2 frame this function is called. It
* checks SAP and connection of received pdu and passes frame to
diff --git a/net/llc/llc_pdu.c b/net/llc/llc_pdu.c
index 2e6cb79196bb..792d195c8bae 100644
--- a/net/llc/llc_pdu.c
+++ b/net/llc/llc_pdu.c
@@ -25,7 +25,7 @@ void llc_pdu_set_cmd_rsp(struct sk_buff *skb, u8 pdu_type)
/**
* pdu_set_pf_bit - sets poll/final bit in LLC header
- * @pdu_frame: input frame that p/f bit must be set into it.
+ * @skb: Frame to set bit in
* @bit_value: poll/final bit (0 or 1).
*
* This function sets poll/final bit in LLC header (based on type of PDU).
diff --git a/net/llc/llc_sap.c b/net/llc/llc_sap.c
index be419062e19a..6805ce43a055 100644
--- a/net/llc/llc_sap.c
+++ b/net/llc/llc_sap.c
@@ -37,6 +37,7 @@ static int llc_mac_header_len(unsigned short devtype)
/**
* llc_alloc_frame - allocates sk_buff for frame
+ * @sk: socket to allocate frame to
* @dev: network device this skb will be sent over
* @type: pdu type to allocate
* @data_size: data size to allocate
@@ -273,6 +274,7 @@ void llc_build_and_send_xid_pkt(struct llc_sap *sap, struct sk_buff *skb,
* llc_sap_rcv - sends received pdus to the sap state machine
* @sap: current sap component structure.
* @skb: received frame.
+ * @sk: socket to associate to frame
*
* Sends received pdus to the sap state machine.
*/
@@ -379,6 +381,7 @@ static void llc_do_mcast(struct llc_sap *sap, struct sk_buff *skb,
* llc_sap_mcast - Deliver multicast PDU's to all matching datagram sockets.
* @sap: SAP
* @laddr: address of local LLC (MAC + SAP)
+ * @skb: PDU to deliver
*
* Search socket list of the SAP and finds connections with same sap.
* Deliver clone to each.
--
2.27.0.rc2
next prev parent reply other threads:[~2020-07-12 23:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-12 23:14 [PATCH net-next 00/20] net simple kerneldoc fixes Andrew Lunn
2020-07-12 23:14 ` [PATCH net-next 01/20] net: 9p: " Andrew Lunn
2020-07-13 8:13 ` Dominique Martinet
2020-07-12 23:14 ` [PATCH net-next 02/20] net: can: " Andrew Lunn
2020-07-12 23:14 ` [PATCH net-next 03/20] net: core: " Andrew Lunn
2020-07-12 23:15 ` [PATCH net-next 04/20] net: dccp: " Andrew Lunn
2020-07-12 23:15 ` [PATCH net-next 05/20] net: decnet: " Andrew Lunn
2020-07-12 23:15 ` [PATCH net-next 06/20] net: ipv4: " Andrew Lunn
2020-07-13 16:38 ` Paul Moore
2020-07-12 23:15 ` [PATCH net-next 07/20] net: ipv6: " Andrew Lunn
2020-07-12 23:15 ` Andrew Lunn [this message]
2020-07-12 23:15 ` [PATCH net-next 09/20] net: mac80211: " Andrew Lunn
2020-07-12 23:15 ` [PATCH net-next 10/20] net: netfilter: " Andrew Lunn
2020-07-12 23:15 ` [PATCH net-next 11/20] net: netlabel: " Andrew Lunn
2020-07-13 16:40 ` Paul Moore
2020-07-12 23:15 ` [PATCH net-next 12/20] net: nfc: " Andrew Lunn
2020-07-12 23:15 ` [PATCH net-next 13/20] net: openvswitch: " Andrew Lunn
2020-07-12 23:15 ` [PATCH net-next 14/20] net: rxrpc: " Andrew Lunn
2020-07-12 23:15 ` [PATCH net-next 15/20] net: sched: " Andrew Lunn
2020-07-12 23:15 ` [PATCH net-next 16/20] net: socket: Move kerneldoc next to function it documents Andrew Lunn
2020-07-12 23:15 ` [PATCH net-next 17/20] net: switchdev: kerneldoc fixes Andrew Lunn
2020-07-12 23:15 ` [PATCH net-next 18/20] net: tipc: " Andrew Lunn
2020-07-13 14:10 ` Jon Maloy
2020-07-12 23:15 ` [PATCH net-next 19/20] net: wireless: " Andrew Lunn
2020-07-12 23:15 ` [PATCH net-next 20/20] net: x25: " Andrew Lunn
2020-07-14 0:20 ` [PATCH net-next 00/20] net simple " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200712231516.1139335-9-andrew@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).