From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=WDCm=AY=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 7BABAC433E2
	for <netdev@archiver.kernel.org>; Mon, 13 Jul 2020 23:08:37 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 58379214D8
	for <netdev@archiver.kernel.org>; Mon, 13 Jul 2020 23:08:37 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1594681717;
	bh=h9Pw3VkY1VDTGmkKAB9QJBdvVcRuqZayaqH8bPjk9rI=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From;
	b=hJbHlZlPkBMmoxbJ94aEawMRbC4JNzIuoeP8aqWZqo//hDDeHnjGIEEmnq7CnHH0X
	 bdqxff1SIwDAx+1BlnUjKV7enDZmUmswWL1D13aAUKjtfdVNnWujD1t6BedJsUeIto
	 J3UF0uCWWDPu8tKhCBSz3Ruwi4FwoUGDun2OZyjM=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726795AbgGMXIg (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Mon, 13 Jul 2020 19:08:36 -0400
Received: from mail.kernel.org ([198.145.29.99]:42048 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726364AbgGMXIg (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 13 Jul 2020 19:08:36 -0400
Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.6])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id C16392065F;
        Mon, 13 Jul 2020 23:08:35 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1594681716;
        bh=h9Pw3VkY1VDTGmkKAB9QJBdvVcRuqZayaqH8bPjk9rI=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=TXtCAriu9l66KQTYa5AAA/rreZhRvpZJZ7CcK3VF/Y21MZy+EfpRrZ4DrQfs6+m8f
         St4KSyjpU4L1/JFBn84mLbqpYE9wsnpTWo4UIxS6EGISIgQhAf7jh1HRl5un5SKVgW
         kIqFQNCZKwPkjxZVHjCU+YKcgGXQsDI/zkuq+llo=
Date:   Mon, 13 Jul 2020 16:08:34 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Edward Cree <ecree@solarflare.com>
Cc:     <linux-net-drivers@solarflare.com>, <davem@davemloft.net>,
        <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 net-next 04/16] sfc_ef100: skeleton EF100 PF driver
Message-ID: <20200713160834.1bf14e25@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <14ffb6fc-d5a2-ce62-c8e7-6cf6e164bf16@solarflare.com>
References: <dbd87499-161e-09f3-7dec-8b7c13ad02dd@solarflare.com>
        <14ffb6fc-d5a2-ce62-c8e7-6cf6e164bf16@solarflare.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Mon, 13 Jul 2020 12:32:16 +0100 Edward Cree wrote:
> +	if (offset > pci_resource_len(efx->pci_dev, bar) - sizeof(uint32_t) * 2) {

Please remove all the uint32_ts