From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 816D1C433E0 for ; Mon, 13 Jul 2020 16:47:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A6F320771 for ; Mon, 13 Jul 2020 16:47:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729855AbgGMQrc (ORCPT ); Mon, 13 Jul 2020 12:47:32 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:33008 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729687AbgGMQrc (ORCPT ); Mon, 13 Jul 2020 12:47:32 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1jv1c0-004tPm-Cx; Mon, 13 Jul 2020 18:47:28 +0200 Date: Mon, 13 Jul 2020 18:47:28 +0200 From: Andrew Lunn To: Vladimir Oltean Cc: davem@davemloft.net, netdev@vger.kernel.org, f.fainelli@gmail.com, vivien.didelot@gmail.com, xiyou.wangcong@gmail.com, ap420073@gmail.com Subject: Re: [PATCH net] net: dsa: link interfaces with the DSA master to get rid of lockdep warnings Message-ID: <20200713164728.GH1078057@lunn.ch> References: <20200713162443.2510682-1-olteanv@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200713162443.2510682-1-olteanv@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > diff --git a/net/dsa/slave.c b/net/dsa/slave.c > index 743caabeaaa6..a951b2a7d79a 100644 > --- a/net/dsa/slave.c > +++ b/net/dsa/slave.c > @@ -1994,6 +1994,13 @@ int dsa_slave_create(struct dsa_port *port) > ret, slave_dev->name); > goto out_phy; > } > + rtnl_lock(); > + ret = netdev_upper_dev_link(master, slave_dev, NULL); > + rtnl_unlock(); > + if (ret) { > + unregister_netdevice(slave_dev); > + goto out_phy; > + } Hi Vladimir A common pattern we see in bugs is that the driver sets up something critical after calling register_netdev(), not realising that that call can go off and really start using the interface before it returns. So in general, i like to have register_netdev() last, nothing after it. Please could you move this before register_netdev(). Thanks Andrew