From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF23CC433E0 for ; Tue, 14 Jul 2020 20:32:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98D05206F4 for ; Tue, 14 Jul 2020 20:32:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726720AbgGNUcS (ORCPT ); Tue, 14 Jul 2020 16:32:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725997AbgGNUcS (ORCPT ); Tue, 14 Jul 2020 16:32:18 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08C36C061755 for ; Tue, 14 Jul 2020 13:32:18 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 5E53215E21F1A; Tue, 14 Jul 2020 13:32:17 -0700 (PDT) Date: Tue, 14 Jul 2020 13:32:16 -0700 (PDT) Message-Id: <20200714.133216.319021019310697324.davem@davemloft.net> To: rakeshs.lkm@gmail.com Cc: sbhatta@marvell.com, sgoutham@marvell.com, jerinj@marvell.com, rsaladi2@marvell.com, kuba@kernel.org, netdev@vger.kernel.org, Sunil.Goutham@cavium.com Subject: Re: [net-next PATCH 1/2] octeontx2-af: add npa error af interrupt handlers From: David Miller In-Reply-To: <20200714063825.24369-2-rakeshs.lkm@gmail.com> References: <20200714063825.24369-1-rakeshs.lkm@gmail.com> <20200714063825.24369-2-rakeshs.lkm@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 14 Jul 2020 13:32:17 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: rakeshs.lkm@gmail.com Date: Tue, 14 Jul 2020 12:08:24 +0530 > +static const char *rvu_npa_inpq_to_str(u16 in) > +{ > + switch (in) { > + case 0: > + return NULL; > + case BIT(NPA_INPQ_NIX0_RX): > + return __stringify(NPA_INPQ_NIX0_RX); Hardware can report anything, multiple bits set at once, garbage values, etc. So to me it doesn't make much sense to expect only one bit set and only handle specific well defined bits. This is the error path in an interrupt handler, just print the raw bits instead of trying to pretty print them please. > +static irqreturn_t rvu_npa_af_gen_intr_handler(int irq, void *rvu_irq) > +{ > + struct rvu *rvu = (struct rvu *)rvu_irq; Void pointers never need to be cast to another type of pointer. Please fix this up in your entire submission.