From: Greg KH <gregkh@linuxfoundation.org>
To: Wxcafé <wxcafe@wxcafe.net>
Cc: "Miguel Rodríguez Pérez" <miguel@det.uvigo.gal>,
oliver@neukum.org, linux-usb@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v3 1/4] Simplify usbnet_cdc_update_filter
Date: Tue, 14 Jul 2020 08:06:28 +0200 [thread overview]
Message-ID: <20200714060628.GC657428@kroah.com> (raw)
In-Reply-To: <b02575d7937188167ed711a403e6d9fa3f80e60d.camel@wxcafe.net>
On Mon, Jul 13, 2020 at 04:43:11PM -0400, Wxcafé wrote:
> Hey,
>
> I've encountered that same problem a few days ago, found this thread
> and these (unmerged) patches, "ported" them to a more current version
> of the kernel (wasn't much work, let's be honest), and I was wondering
> if it would be possible to get them merged, because this is still a
> problem with cdc_ncm.
>
> Here's the three "up to date" patches (based on 5.8-rc5), they work
> insofar as I'm running with them, the bug isn't there anymore (I get
> ethernet multicast packets correctly), and there's no obvious bug. I'm
> not a dev though, so I have no idea if these are formatted correctly,
> if the patch separation is correct, or anything like that, I just think
> it would be great if this could be merged into mainline!
You need to submit them in a format they can be applied in, as well as
taking care of the issues that caused Oliver to not agree with them.
thanks,
greg k-h
next prev parent reply other threads:[~2020-07-14 6:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-30 17:32 [PATCH v2 1/4] Simplify usbnet_cdc_update_filter Miguel Rodríguez Pérez
2018-07-01 8:15 ` Greg KH
2018-07-01 9:05 ` [PATCH v3 0/4] usbnet: Admit multicast traffic in cdc ncm devices Miguel Rodríguez Pérez
2018-07-01 9:05 ` [PATCH v3 1/4] Simplify usbnet_cdc_update_filter Miguel Rodríguez Pérez
2018-07-02 8:25 ` Oliver Neukum
2018-07-02 11:19 ` Miguel Rodríguez Pérez
2018-07-02 11:28 ` [PATCH v4 1/4] Use dev->intf to get interface information Miguel Rodríguez Pérez
2018-07-02 17:13 ` [PATCH v3 1/4] Simplify usbnet_cdc_update_filter Bjørn Mork
2020-07-13 20:43 ` Wxcafé
2020-07-14 6:06 ` Greg KH [this message]
2020-07-14 15:13 ` Wxcafé
2020-07-14 16:13 ` Greg KH
2018-07-01 9:05 ` [PATCH v3 2/4] Export usbnet_cdc_update_filter Miguel Rodríguez Pérez
2018-07-02 8:26 ` Oliver Neukum
2018-07-01 9:05 ` [PATCH v3 3/4] Replace the way cdc_ncm hooks into usbnet_change_mtu Miguel Rodríguez Pérez
2018-07-04 14:32 ` [PATCH v4 3/4] Add .ndo_set_rx_mode to cdc_ncm_netdev_ops Miguel Rodríguez Pérez
2018-07-04 14:41 ` Miguel Rodríguez Pérez
2018-07-01 9:05 ` [PATCH v3 4/4] Hook into set_rx_mode to admit multicast traffic Miguel Rodríguez Pérez
2018-07-09 9:34 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714060628.GC657428@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=miguel@det.uvigo.gal \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=wxcafe@wxcafe.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).