From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3BAAC433E8 for ; Tue, 14 Jul 2020 16:33:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE46B22464 for ; Tue, 14 Jul 2020 16:33:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594744394; bh=IL/q2MikxWSOCHkTue3ZRfLBYvGD19b9OpRaKqZN4HE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=u6BbHrIHuXdfxKSl2vdHJkTal8fxxteTEtiZPml9mns/YiqixJmoKsD8Dqdf6CMOs T+Cc2+XwRwYAZiJ1N5YcqS2roDJc6slHse85u1EN/J1a4EOgIPfzu632cw8ATk7wXE GSfC9QnbHQvfSzqnMBn9BKpRMU6mmwBWC0V3ME4Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728603AbgGNQdO (ORCPT ); Tue, 14 Jul 2020 12:33:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:54616 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728087AbgGNQdL (ORCPT ); Tue, 14 Jul 2020 12:33:11 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9CF4122464; Tue, 14 Jul 2020 16:33:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594744390; bh=IL/q2MikxWSOCHkTue3ZRfLBYvGD19b9OpRaKqZN4HE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aBVNtA92jLN1dzeOkKemXhxadHbEzUZ2eZQ+DKMaB4hnTHe1lAanPjZSKd32VVfl7 ihmRRaV1w1vMG9UGMiodLeDtekzPAEmnOQgI2Ke18Hr3Ve9Qkn9pWp74K5rXaCfAfo mEcHTjOxe6f1Lya8oUOKdaDH6WEbyMSC0fnieO3E= Date: Tue, 14 Jul 2020 09:33:08 -0700 From: Jakub Kicinski To: Edward Cree , "leon@kernel.org" Cc: , , Subject: Re: [PATCH v2 net-next 04/16] sfc_ef100: skeleton EF100 PF driver Message-ID: <20200714093308.584d69d6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <88664bf2-a0c9-4cb1-b50c-2a5e592fe235@solarflare.com> References: <14ffb6fc-d5a2-ce62-c8e7-6cf6e164bf16@solarflare.com> <20200713160200.681db7aa@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <88664bf2-a0c9-4cb1-b50c-2a5e592fe235@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 14 Jul 2020 10:02:05 +0100 Edward Cree wrote: > On 14/07/2020 00:02, Jakub Kicinski wrote: > > On Mon, 13 Jul 2020 12:32:16 +0100 Edward Cree wrote: =20 > >> +MODULE_VERSION(EFX_DRIVER_VERSION); =20 > > We got rid of driver versions upstream, no? =20 > The sfc driver still has a MODULE_VERSION(), I just made this do > =C2=A0the same.=C2=A0 Should I instead remove the one from sfc as well? Yes, please. Leon, I see there's a bunch of MODULE_VERSIONS() still left - are you planning to take care of those? Perhaps removing them is a good "intern task"? > I assumed there was some reason why it hadn't been included in > =C2=A0the versionectomy so far. versionectomy :)