From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59976C433DF for ; Thu, 16 Jul 2020 15:23:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D835206F5 for ; Thu, 16 Jul 2020 15:23:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594912982; bh=0KOsAGDlyjL10nw8GkoXdEM39Y7GR/xzRunce7+0ZM0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=iGK45FcUBZvbj3jvH0AT64/Q2E76m4KPALCLhSLTTWODvMlwtUXT5f8a4F7VBpA8o xmR1GVuL9Dk0mQQb7+7Y882YOhIOut57f08nWlE0T4tiwqgdmhr2pG0Y2XEI8Sm/c/ AcYWE6LLlqQ2qwNWAp3Jfbs6PfrPhmHr2pkOoD2I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729027AbgGPPXB (ORCPT ); Thu, 16 Jul 2020 11:23:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:43670 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728150AbgGPPXB (ORCPT ); Thu, 16 Jul 2020 11:23:01 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6DAEB2063A; Thu, 16 Jul 2020 15:23:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594912980; bh=0KOsAGDlyjL10nw8GkoXdEM39Y7GR/xzRunce7+0ZM0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CalCSH68LxHalcZAFoeaS74Nol1NtkkX8+dmN1mffM92qmH13dMeQk/cvuRdVdv4S +PKtlwY+7VigrcBMItAaAVzOlnUG3uw+6jq1OqmU5RVJdaM3viMTuDwmeVyXYNKib9 tEmj7rIH6JvrmJ3Ujf6TbyZcZgTzDtU0qrlHTgLo= Date: Thu, 16 Jul 2020 08:22:59 -0700 From: Jakub Kicinski To: Andrii Nakryiko Cc: , , , , , , Subject: Re: [PATCH v3 bpf-next 9/9] bpf, xdp: remove XDP_QUERY_PROG and XDP_QUERY_PROG_HW XDP commands Message-ID: <20200716082259.40600e03@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200716045602.3896926-10-andriin@fb.com> References: <20200716045602.3896926-1-andriin@fb.com> <20200716045602.3896926-10-andriin@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 15 Jul 2020 21:56:01 -0700 Andrii Nakryiko wrote: > Now that BPF program/link management is centralized in generic net_device > code, kernel code never queries program id from drivers, so > XDP_QUERY_PROG/XDP_QUERY_PROG_HW commands are unnecessary. >=20 > This patch removes all the implementations of those commands in kernel, a= long > the xdp_attachment_query(). >=20 > This patch was compile-tested on allyesconfig. >=20 > Signed-off-by: Andrii Nakryiko drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c: In function =E2=80=98dpaa= 2_eth_xdp=E2=80=99: drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:2079:25: warning: unused v= ariable =E2=80=98priv=E2=80=99 [-Wunused-variable] 2079 | struct dpaa2_eth_priv *priv =3D netdev_priv(dev); | ^~~~