From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ED42C433E4 for ; Thu, 16 Jul 2020 18:24:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 57DB02074B for ; Thu, 16 Jul 2020 18:24:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594923877; bh=lUrKAN9yNahYk7DUhEVFApBsMcGwcqcB0K958hQove4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=v/036Pa0tS3A55fYyfp2ptxDx536cM0IokKjp3vmAFLzY1zC+/KLy8JIsvGJelVUx Ij1E+K/7I4j8e9qM1ytmAdw3dOBFEVvqT/JSCcnbJ/NsoEq+BOnWSjQcGZUVdPEjUL W1xXFUzq5MuteYlblY+witktSDCKPY7kJP9a74m4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729211AbgGPSYf (ORCPT ); Thu, 16 Jul 2020 14:24:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:42530 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726986AbgGPSYe (ORCPT ); Thu, 16 Jul 2020 14:24:34 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D609D2074B; Thu, 16 Jul 2020 18:24:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594923874; bh=lUrKAN9yNahYk7DUhEVFApBsMcGwcqcB0K958hQove4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UKdl1ElnQFjpW7KDv9qP3KZasaypvi6rKGvuPkI8JqV+ITm+nFBjSBFQRNZfzwQKS dNlgdYtJt9Op41llLbthsSk6EKgovcbOAQHzR/PsMB14FIJEfSAkN4JDS0dHAFABJr 8HcJS1TtQEihKUgASpgn6ZLKpELaumP4Xm1AxQKE= Date: Thu, 16 Jul 2020 11:24:32 -0700 From: Jakub Kicinski To: Sergey Organov Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Fugang Duan , "David S. Miller" , Richard Cochran , Vladimir Oltean Subject: Re: [PATCH v3 net] net: fec: fix hardware time stamping by external devices Message-ID: <20200716112432.127b9d99@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200714162802.11926-1-sorganov@gmail.com> References: <20200706142616.25192-1-sorganov@gmail.com> <20200714162802.11926-1-sorganov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 14 Jul 2020 19:28:02 +0300 Sergey Organov wrote: > Fix support for external PTP-aware devices such as DSA or PTP PHY: > > Make sure we never time stamp tx packets when hardware time stamping > is disabled. > > Check for PTP PHY being in use and then pass ioctls related to time > stamping of Ethernet packets to the PTP PHY rather than handle them > ourselves. In addition, disable our own hardware time stamping in this > case. > > Fixes: 6605b730c061 ("FEC: Add time stamping code and a PTP hardware clock") > Signed-off-by: Sergey Organov > Acked-by: Richard Cochran > Acked-by: Vladimir Oltean > --- > > v3: > - Fixed SHA1 length of Fixes: tag > - Added Acked-by: tags > > v2: > - Extracted from larger patch series > - Description/comments updated according to discussions > - Added Fixes: tag FWIW in the networking subsystem we like the changelog to be part of the commit. Applied, and added to the stable queue, thanks!