From: David Miller <davem@davemloft.net>
To: kuba@kernel.org
Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com,
ecree@solarflare.com, mhabets@solarflare.com,
mslattery@solarflare.com
Subject: Re: [PATCH net-next] efx: convert to new udp_tunnel infrastructure
Date: Fri, 17 Jul 2020 18:34:59 -0700 (PDT) [thread overview]
Message-ID: <20200717.183459.1613002913279592264.davem@davemloft.net> (raw)
In-Reply-To: <20200717235336.879264-1-kuba@kernel.org>
From: Jakub Kicinski <kuba@kernel.org>
Date: Fri, 17 Jul 2020 16:53:36 -0700
> Check MC_CMD_DRV_ATTACH_EXT_OUT_FLAG_TRUSTED, before setting
> the info, which will hopefully protect us from -EPERM errors
> the previous code was gracefully ignoring. Shared code reports
> the port information back to user space, so we really want
> to know what was added and what failed.
>
> The driver does not call udp_tunnel_get_rx_info(), so its own
> management of table state is not really all that problematic,
> we can leave it be. This allows the driver to continue with its
> copious table syncing, and matching the ports to TX frames,
> which it will reportedly do one day.
>
> Leave the feature checking in the callbacks, as the device may
> remove the capabilities on reset.
>
> Inline the loop from __efx_ef10_udp_tnl_lookup_port() into
> efx_ef10_udp_tnl_has_port(), since it's the only caller now.
>
> With new infra this driver gains port replace - when space frees
> up in a full table a new port will be selected for offload.
> Plus efx will no longer sleep in an atomic context.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Edward et al., please review.
Thank you.
next prev parent reply other threads:[~2020-07-18 1:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 23:53 [PATCH net-next] efx: convert to new udp_tunnel infrastructure Jakub Kicinski
2020-07-18 1:34 ` David Miller [this message]
2020-07-20 11:45 ` Edward Cree
2020-07-20 17:21 ` Jakub Kicinski
2020-07-21 12:05 ` Edward Cree
2020-07-21 19:48 ` Jakub Kicinski
2020-07-22 10:31 ` Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717.183459.1613002913279592264.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=kuba@kernel.org \
--cc=linux-net-drivers@solarflare.com \
--cc=mhabets@solarflare.com \
--cc=mslattery@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).