From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E0B0C433E4 for ; Mon, 20 Jul 2020 16:35:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DDD3220734 for ; Mon, 20 Jul 2020 16:35:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=wp.pl header.i=@wp.pl header.b="FYBCbTFU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388962AbgGTQfL (ORCPT ); Mon, 20 Jul 2020 12:35:11 -0400 Received: from mx4.wp.pl ([212.77.101.11]:45144 "EHLO mx4.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731566AbgGTPyd (ORCPT ); Mon, 20 Jul 2020 11:54:33 -0400 Received: (wp-smtpd smtp.wp.pl 16606 invoked from network); 20 Jul 2020 17:54:30 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1595260471; bh=Y0bZYOg1d1EJBOpSBHiUjDo02WQDRKDZBBBZtcRjU7Y=; h=From:To:Cc:Subject; b=FYBCbTFUnDIBtbI8nTQmeLGktKbYGctKcXLK3jORi7mXETEucsm7LCdpr4Bf1uKX8 bbYHCWx/1KOkegDqDqRBH/pctdGFLWPUKKjFjq5ON0hd/U10aiHTiJHn9vsPgTrx73 9GR+tLSiaIUzFWokKbrx3Qq3gQwhVaQ05ylNKn3E= Received: from unknown (HELO kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com) (kubakici@wp.pl@[163.114.132.7]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 20 Jul 2020 17:54:30 +0200 Date: Mon, 20 Jul 2020 08:54:22 -0700 From: Jakub Kicinski To: Navid Emamdoost Cc: Kalle Valo , "David S. Miller" , Matthias Brugger , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mt7601u: add missing release on skb in mt7601u_mcu_msg_send Message-ID: <20200720085422.40539aa4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200718052630.11032-1-navid.emamdoost@gmail.com> References: <20200718052630.11032-1-navid.emamdoost@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-WP-MailID: 86ad31f636f93e20d39630a6dd07675f X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 0000001 [geJz] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 18 Jul 2020 00:26:29 -0500 Navid Emamdoost wrote: > In the implementation of mt7601u_mcu_msg_send(), skb is supposed to be > consumed on all execution paths. Release skb before returning if > test_bit() fails. > > Signed-off-by: Navid Emamdoost Acked-by: Jakub Kicinski