From: Stephen Hemminger <stephen@networkplumber.org>
To: Sriram Krishnan <srirakr2@cisco.com>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>,
mbumgard@cisco.com, ugm@cisco.com, nimm@cisco.com,
xe-linux-external@cisco.com,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-hyperv@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] net: hyperv: add support for vlans in netvsc driver
Date: Mon, 20 Jul 2020 10:34:25 -0700 [thread overview]
Message-ID: <20200720103425.03a05912@hermes.lan> (raw)
In-Reply-To: <20200720164551.14153-1-srirakr2@cisco.com>
On Mon, 20 Jul 2020 22:15:51 +0530
Sriram Krishnan <srirakr2@cisco.com> wrote:
>
> + /* When using AF_PACKET we need to remove VLAN from frame
> + * and indicate VLAN information in SKB so HOST OS will
> + * transmit the VLAN frame
> + */
> + if (skb->protocol == htons(ETH_P_8021Q)) {
> + u16 vlan_tci = 0;
> + skb_reset_mac_header(skb);
> + if (eth_type_vlan(eth_hdr(skb)->h_proto)) {
> + int pop_err;
> + pop_err = __skb_vlan_pop(skb, &vlan_tci);
> + if (likely(pop_err == 0)) {
> + __vlan_hwaccel_put_tag(skb, htons(ETH_P_8021Q), vlan_tci);
> +
> + /* Update the NDIS header pkt lengths */
> + packet->total_data_buflen -= VLAN_HLEN;
> + rndis_msg->msg_len = packet->total_data_buflen;
> + rndis_msg->msg.pkt.data_len = packet->total_data_buflen;
> +
> + } else {
> + netdev_err(net,"Pop vlan err %x\n",pop_err);
> + }
> + }
> + }
Minor comments.
1. Blank line between declaration and code.
2. Error handling is different than other parts of this code.
probably just need a goto drop on error.
It seems like you are putting into message, then driver is putting
it into meta-data in next code block. Maybe it should be combined?
next prev parent reply other threads:[~2020-07-20 17:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 16:45 [PATCH v3] net: hyperv: add support for vlans in netvsc driver Sriram Krishnan
2020-07-20 17:34 ` Stephen Hemminger [this message]
2020-07-20 17:45 ` Haiyang Zhang
2020-07-20 17:51 ` Haiyang Zhang
2020-07-20 23:27 ` David Miller
2020-07-21 7:09 ` Sriram Krishnan (srirakr2)
2020-07-21 22:18 ` Haiyang Zhang
2020-07-22 10:44 ` Sriram Krishnan (srirakr2)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720103425.03a05912@hermes.lan \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=haiyangz@microsoft.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbumgard@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=nimm@cisco.com \
--cc=srirakr2@cisco.com \
--cc=sthemmin@microsoft.com \
--cc=ugm@cisco.com \
--cc=wei.liu@kernel.org \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).