From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E82FDC433E0 for ; Wed, 22 Jul 2020 20:04:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCC0322B42 for ; Wed, 22 Jul 2020 20:04:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732543AbgGVUEK (ORCPT ); Wed, 22 Jul 2020 16:04:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726535AbgGVUEJ (ORCPT ); Wed, 22 Jul 2020 16:04:09 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE79FC0619DC for ; Wed, 22 Jul 2020 13:04:09 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 4331C11FFCC2A; Wed, 22 Jul 2020 12:47:24 -0700 (PDT) Date: Wed, 22 Jul 2020 13:04:08 -0700 (PDT) Message-Id: <20200722.130408.2000579366934431355.davem@davemloft.net> To: geffrey.guo@huawei.com Cc: kuba@kernel.org, maheshb@google.com, edumazet@google.com, netdev@vger.kernel.org Subject: Re: [PATCH,v2] ipvlan: add the check of ip header checksum From: David Miller In-Reply-To: <1595409499-25008-1-git-send-email-geffrey.guo@huawei.com> References: <1595409499-25008-1-git-send-email-geffrey.guo@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 22 Jul 2020 12:47:24 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: guodeqing Date: Wed, 22 Jul 2020 17:18:19 +0800 > The ip header checksum can be error in the following steps. You did not respond to my feedback from your previous submissions. Packets created inside of the kernel have correct checksums, and the ipvlan driver can depend upon this precondition. I am not applying this patch, sorry.