From: David Miller <davem@davemloft.net>
To: richard_siegfried@systemli.org
Cc: gerrit@erg.abdn.ac.uk, dccp@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v5] net: dccp: Add SIOCOUTQ IOCTL support (send buffer fill)
Date: Wed, 22 Jul 2020 17:01:12 -0700 (PDT) [thread overview]
Message-ID: <20200722.170112.664348766467297694.davem@davemloft.net> (raw)
In-Reply-To: <20200720160614.117090-1-richard_siegfried@systemli.org>
From: Richard Sailer <richard_siegfried@systemli.org>
Date: Mon, 20 Jul 2020 18:06:14 +0200
> This adds support for the SIOCOUTQ IOCTL to get the send buffer fill
> of a DCCP socket, like UDP and TCP sockets already have.
>
> Regarding the used data field: DCCP uses per packet sequence numbers,
> not per byte, so sequence numbers can't be used like in TCP. sk_wmem_queued
> is not used by DCCP and always 0, even in test on highly congested paths.
> Therefore this uses sk_wmem_alloc like in UDP.
>
> Signed-off-by: Richard Sailer <richard_siegfried@systemli.org>
> ---
> v5: More infos into dccp.rst, +empty line after declarations
Applied, but I wonder if you'll also need something like tcp's SIOCOUTQNSD?
next prev parent reply other threads:[~2020-07-23 0:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 16:06 [PATCH net-next v5] net: dccp: Add SIOCOUTQ IOCTL support (send buffer fill) Richard Sailer
2020-07-23 0:01 ` David Miller [this message]
2020-07-23 10:28 ` Richard Sailer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722.170112.664348766467297694.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dccp@vger.kernel.org \
--cc=gerrit@erg.abdn.ac.uk \
--cc=netdev@vger.kernel.org \
--cc=richard_siegfried@systemli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).