From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=vyP2=BC=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id D7868C433E0
	for <netdev@archiver.kernel.org>; Thu, 23 Jul 2020 00:31:35 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id BDEDD2071A
	for <netdev@archiver.kernel.org>; Thu, 23 Jul 2020 00:31:35 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1733075AbgGWAbf (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Wed, 22 Jul 2020 20:31:35 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60876 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726685AbgGWAbe (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 22 Jul 2020 20:31:34 -0400
Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8F7CC0619DC
        for <netdev@vger.kernel.org>; Wed, 22 Jul 2020 17:31:34 -0700 (PDT)
Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 9E81E11FFCC2A;
        Wed, 22 Jul 2020 17:14:49 -0700 (PDT)
Date:   Wed, 22 Jul 2020 17:31:34 -0700 (PDT)
Message-Id: <20200722.173134.594466541827728596.davem@davemloft.net>
To:     vincent.ldev@duvert.net
Cc:     netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] appletalk: Improve handling of broadcast packets
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200722113752.1218-2-vincent.ldev@duvert.net>
References: <20200722113752.1218-1-vincent.ldev@duvert.net>
        <20200722113752.1218-2-vincent.ldev@duvert.net>
X-Mailer: Mew version 6.8 on Emacs 26.3
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 22 Jul 2020 17:14:49 -0700 (PDT)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: Vincent Duvert <vincent.ldev@duvert.net>
Date: Wed, 22 Jul 2020 13:37:52 +0200

> @@ -89,6 +89,7 @@ static struct sock *atalk_search_socket(struct sockaddr_at *to,
>  					struct atalk_iface *atif)
>  {
>  	struct sock *s;
> +	struct sock *def_socket = NULL;
>  
>  	read_lock_bh(&atalk_sockets_lock);
>  	sk_for_each(s, &atalk_sockets) {

Please use reverse christmas tree ordering for local variables.

Also, please post the next revision of this patch series with
a proper "[PATCH net 0/N]" header posting, explaining what the
patch series is doing, how it is doing it, and why it is
doing it this way.

Your Subject lines should all also indicate the proper target GIT tree
your changes are for.  This is indicated in the "[]" bracket area,
as either 'net' or 'net-next', f.e. "[PATCH net 1/2] ..."

Thank you.