From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05952C433E1 for ; Thu, 23 Jul 2020 00:52:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DBAC42086A for ; Thu, 23 Jul 2020 00:52:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733175AbgGWAwg (ORCPT ); Wed, 22 Jul 2020 20:52:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728607AbgGWAwf (ORCPT ); Wed, 22 Jul 2020 20:52:35 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A494AC0619DC for ; Wed, 22 Jul 2020 17:52:35 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 591E512662B52; Wed, 22 Jul 2020 17:35:50 -0700 (PDT) Date: Wed, 22 Jul 2020 17:52:34 -0700 (PDT) Message-Id: <20200722.175234.1233062940950818707.davem@davemloft.net> To: claudiu.manoil@nxp.com Cc: netdev@vger.kernel.org Subject: Re: [PATCH net v2] enetc: Remove the mdio bus on PF probe bailout From: David Miller In-Reply-To: <1595428812-28995-1-git-send-email-claudiu.manoil@nxp.com> References: <1595428812-28995-1-git-send-email-claudiu.manoil@nxp.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 22 Jul 2020 17:35:50 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Claudiu Manoil Date: Wed, 22 Jul 2020 17:40:12 +0300 > For ENETC ports that register an external MDIO bus, > the bus doesn't get removed on the error bailout path > of enetc_pf_probe(). > > This issue became much more visible after recent: > commit 07095c025ac2 ("net: enetc: Use DT protocol information to set up the ports") > Before this commit, one could make probing fail on the error > path only by having register_netdev() fail, which is unlikely. > But after this commit, because it moved the enetc_of_phy_get() > call up in the probing sequence, now we can trigger an mdiobus_free() > bug just by forcing enetc_alloc_msix() to return error, i.e. with the > 'pci=nomsi' kernel bootarg (since ENETC relies on MSI support to work), > as the calltrace below shows: ... > Fixes: ebfcb23d62ab ("enetc: Add ENETC PF level external MDIO support") > Signed-off-by: Claudiu Manoil Applied and queued up for -stable, thanks.