From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FB67C433E0 for ; Tue, 28 Jul 2020 00:59:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E93220809 for ; Tue, 28 Jul 2020 00:59:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595897980; bh=TiJ2nFSx8p/oc0Ub+qEvsRg4KkH6dx4FIb4AaU6zuZI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=c+3lRJFJaktpfCehCmMdADCTBb+z8YZFHUYw0Br4zdnwvp5TnEAd+/61S+FaJTswg NWBAQaRhyQYFLCHUVg3fsO+kdLUQe6OSnINZIHTSSlhu5Hq1V/zDenSL6ejNiLD7Gl JwUvuBug5g2tDwpdLWVHV2ib3vamrpx/d9E+g5ZE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726884AbgG1A7i (ORCPT ); Mon, 27 Jul 2020 20:59:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:56574 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726139AbgG1A7h (ORCPT ); Mon, 27 Jul 2020 20:59:37 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1B17820809; Tue, 28 Jul 2020 00:59:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595897977; bh=TiJ2nFSx8p/oc0Ub+qEvsRg4KkH6dx4FIb4AaU6zuZI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HPgGTKhzVQIqJlZQWf9fKC4GGP9qR0R8UsSCWCT/3EY8DjfyGXgByhvnZKpA4nZdc m7BpwZpRfN8W7w2+7Mbv9KMl5AfhqJx7utGWzEFtvdO3h8NhtuhNfB5eo7fcmUGMoE vwpdHw6XA/woh3W9ihuMpvHSl5WhOqNBk7bk+9yQ= Date: Mon, 27 Jul 2020 17:59:35 -0700 From: Jakub Kicinski To: Moshe Shemesh Cc: "David S. Miller" , Jiri Pirko , Vasundhara Volam , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next RFC 09/13] devlink: Add enable_remote_dev_reset generic parameter Message-ID: <20200727175935.0785102a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <1595847753-2234-10-git-send-email-moshe@mellanox.com> References: <1595847753-2234-1-git-send-email-moshe@mellanox.com> <1595847753-2234-10-git-send-email-moshe@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 27 Jul 2020 14:02:29 +0300 Moshe Shemesh wrote: > The enable_remote_dev_reset devlink param flags that the host admin > allows device resets that can be initiated by other hosts. This > parameter is useful for setups where a device is shared by different > hosts, such as multi-host setup. Once the user set this parameter to > false, the driver should NACK any attempt to reset the device while the > driver is loaded. > > Signed-off-by: Moshe Shemesh There needs to be a devlink event generated when reset is triggered (remotely or not). You're also missing failure reasons. Users need to know if the reset request was clearly nacked by some host, not supported, etc. vs unexpected failure.