From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A812C433E1 for ; Tue, 28 Jul 2020 01:48:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E1F9D20672 for ; Tue, 28 Jul 2020 01:48:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726410AbgG1BsT (ORCPT ); Mon, 27 Jul 2020 21:48:19 -0400 Received: from smtp1.emailarray.com ([65.39.216.14]:61402 "EHLO smtp1.emailarray.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726196AbgG1BsS (ORCPT ); Mon, 27 Jul 2020 21:48:18 -0400 Received: (qmail 65444 invoked by uid 89); 28 Jul 2020 01:48:16 -0000 Received: from unknown (HELO localhost) (amxlbW9uQGZsdWdzdmFtcC5jb21AMTYzLjExNC4xMzIuMw==) (POLARISLOCAL) by smtp1.emailarray.com with SMTP; 28 Jul 2020 01:48:16 -0000 Date: Mon, 27 Jul 2020 18:48:12 -0700 From: Jonathan Lemon To: Christoph Hellwig Cc: netdev@vger.kernel.org, kernel-team@fb.com, robin.murphy@arm.com, akpm@linux-foundation.org, davem@davemloft.net, kuba@kernel.org, willemb@google.com, edumazet@google.com, steffen.klassert@secunet.com, saeedm@mellanox.com, maximmi@mellanox.com, bjorn.topel@intel.com, magnus.karlsson@intel.com, borisp@mellanox.com, david@redhat.com Subject: Re: [RFC PATCH v2 21/21] netgpu/nvidia: add Nvidia plugin for netgpu Message-ID: <20200728014812.izihmnon3khzyr32@bsd-mbp.dhcp.thefacebook.com> References: <20200727052846.4070247-1-jonathan.lemon@gmail.com> <20200727052846.4070247-22-jonathan.lemon@gmail.com> <20200727073509.GB3917@lst.de> <20200727170003.clx5ytf7vn2emhvl@bsd-mbp.dhcp.thefacebook.com> <20200727182424.GA10178@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200727182424.GA10178@lst.de> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jul 27, 2020 at 08:24:25PM +0200, Christoph Hellwig wrote: > On Mon, Jul 27, 2020 at 10:00:03AM -0700, Jonathan Lemon wrote: > > On Mon, Jul 27, 2020 at 09:35:09AM +0200, Christoph Hellwig wrote: > > > Seriously? If you only even considered this is something reasonable > > > to do you should not be anywhere near Linux kernel development. > > > > > > Just go away! > > > > This isn't really a constructive comment. > > And this wasn't a constructive patch. If you really think adding tons > of garbage to the kernel to support a proprietary driver you really > should not be here at all. This is not in support of a proprietary driver. As the cover letter notes, this is for data transfers between the NIC/GPU, while still utilizing the kernel protocol stack and leaving the application in control. While the current GPU utilized is nvidia, there's nothing in the rest of the patches specific to Nvidia - an Intel or AMD GPU interface could be equally workable. I think this is a better patch than all the various implementations of the protocol stack in the form of RDMA, driver code and device firmware. I'm aware that Nvidia code is maintained outside the tree, so this last patch may better placed there; I included it here so reviewers can see how things work. -- Jonathan