From: Bruno Thomsen <bruno.thomsen@gmail.com>
To: netdev <netdev@vger.kernel.org>
Cc: Bruno Thomsen <bruno.thomsen@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Fabio Estevam <festevam@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Heiner Kallweit <hkallweit1@gmail.com>,
Lars Alex Pedersen <laa@kamstrup.com>,
Bruno Thomsen <bth@kamstrup.com>
Subject: [PATCH 1/2] net: mdiobus: reset deassert delay
Date: Tue, 28 Jul 2020 11:02:02 +0200 [thread overview]
Message-ID: <20200728090203.17313-1-bruno.thomsen@gmail.com> (raw)
The current reset logic only has a delay during assert.
This reuses the delay value as deassert delay to ensure
PHYs are ready for commands. Delays are typically needed
when external hardware slows down reset release with a
RC network. This solution does not need any new device
tree bindings.
It also improves handling of long delays (>20ms) by using
the generic fsleep() for selecting appropriate delay
function.
Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
---
drivers/net/phy/mdio_bus.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index 6ceee82b2839..84d5ab07fe16 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c
@@ -627,8 +627,9 @@ int __mdiobus_register(struct mii_bus *bus, struct module *owner)
bus->reset_gpiod = gpiod;
gpiod_set_value_cansleep(gpiod, 1);
- udelay(bus->reset_delay_us);
+ fsleep(bus->reset_delay_us);
gpiod_set_value_cansleep(gpiod, 0);
+ fsleep(bus->reset_delay_us);
}
if (bus->reset) {
base-commit: 92ed301919932f777713b9172e525674157e983d
--
2.26.2
next reply other threads:[~2020-07-28 9:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 9:02 Bruno Thomsen [this message]
2020-07-28 9:02 ` [PATCH 2/2] dt-bindings: net: mdio: update reset-delay-us description Bruno Thomsen
2020-07-28 12:32 ` [PATCH 1/2] net: mdiobus: reset deassert delay Fabio Estevam
2020-07-28 12:49 ` Bruno Thomsen
2020-07-28 18:47 ` Andrew Lunn
2020-07-28 18:41 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728090203.17313-1-bruno.thomsen@gmail.com \
--to=bruno.thomsen@gmail.com \
--cc=andrew@lunn.ch \
--cc=bth@kamstrup.com \
--cc=f.fainelli@gmail.com \
--cc=festevam@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=laa@kamstrup.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).