From: Jakub Kicinski <kuba@kernel.org>
To: David Thompson <dthompson@mellanox.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, jiri@mellanox.com,
Asmaa Mnebhi <asmaa@mellanox.com>
Subject: Re: [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver
Date: Wed, 29 Jul 2020 13:49:15 -0700 [thread overview]
Message-ID: <20200729134915.5896edc3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <1596047355-28777-1-git-send-email-dthompson@mellanox.com>
On Wed, 29 Jul 2020 14:29:15 -0400 David Thompson wrote:
> This patch adds build and driver logic for the "mlxbf_gige"
> Ethernet driver from Mellanox Technologies.
Please fix these W=1 C=1 warnings:
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:256:29: warning: Using plain integer as NULL pointer
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:258:29: warning: Using plain integer as NULL pointer
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:292:29: warning: Using plain integer as NULL pointer
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:294:23: warning: Using plain integer as NULL pointer
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:296:29: warning: Using plain integer as NULL pointer
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:329:25: warning: incorrect type in assignment (different base types)
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:329:25: expected unsigned long long [usertype]
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:329:25: got restricted __be64 [usertype]
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c: In function ‘mlxbf_gige_initial_mac’:
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:1093:6: warning: variable ‘status’ set but not used [-Wunused-but-set-variable]
1093 | int status;
| ^~~~~~
next prev parent reply other threads:[~2020-07-29 20:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 18:29 [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver David Thompson
2020-07-29 19:41 ` David Thompson
2020-07-29 20:31 ` David Miller
2020-07-29 20:49 ` Jakub Kicinski [this message]
2020-07-30 4:03 ` kernel test robot
2020-07-31 17:42 ` Andrew Lunn
[not found] ` <VI1PR05MB4110070900CF42CB3E18983EDA4E0@VI1PR05MB4110.eurprd05.prod.outlook.com>
2020-07-31 19:54 ` Andrew Lunn
2020-07-31 21:38 ` Asmaa Mnebhi
2020-08-01 1:14 ` Andrew Lunn
2020-08-03 14:23 ` Asmaa Mnebhi
2020-08-11 19:53 ` Asmaa Mnebhi
2020-08-11 20:06 ` Andrew Lunn
2020-08-12 20:37 ` Asmaa Mnebhi
2020-08-12 21:34 ` Andrew Lunn
2020-07-31 18:37 ` Andrew Lunn
2020-08-28 14:29 ` Asmaa Mnebhi
2020-07-31 18:38 ` Andrew Lunn
2020-08-28 14:24 ` Asmaa Mnebhi
2020-08-28 14:36 ` Andrew Lunn
2020-07-31 18:41 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729134915.5896edc3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=asmaa@mellanox.com \
--cc=davem@davemloft.net \
--cc=dthompson@mellanox.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).