From: Jakub Kicinski <kuba@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: netdev@vger.kernel.org, Jiri Pirko <jiri@mellanox.com>,
Jonathan Corbet <corbet@lwn.net>,
Michael Chan <michael.chan@broadcom.com>,
Bin Luo <luobin9@huawei.com>,
Saeed Mahameed <saeedm@mellanox.com>,
Leon Romanovsky <leon@kernel.org>,
Ido Schimmel <idosch@mellanox.com>,
Danielle Ratson <danieller@mellanox.com>
Subject: Re: [net-next 0/4] devlink flash update overwrite mask
Date: Thu, 30 Jul 2020 17:39:28 -0700 [thread overview]
Message-ID: <20200730173928.676a7a29@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200730232008.2648488-1-jacob.e.keller@intel.com>
LGTM,
minor suggestions:
- could you add opt-in support flags to struct devlink_ops, a'la
ethtool_ops->supported_coalesce_params so that you don't have to
modify all drivers to reject unsupported things?
- could you split patch 2 into an ice change and a devlink core
change?
next prev parent reply other threads:[~2020-07-31 0:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 23:20 [net-next 0/4] devlink flash update overwrite mask Jacob Keller
2020-07-30 23:20 ` [net-next 1/4] devlink: convert flash_update to use params structure Jacob Keller
2020-07-30 23:20 ` [net-next 2/4] devlink: introduce flash update overwrite mask Jacob Keller
2020-07-30 23:20 ` [iproute2-next 3/4] Update devlink header for overwrite mask attribute Jacob Keller
2020-07-30 23:20 ` [iproute2-next 4/4] devlink: support setting the overwrite mask Jacob Keller
2020-07-31 0:39 ` Jakub Kicinski [this message]
2020-07-31 20:35 ` [net-next 0/4] devlink flash update " Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730173928.676a7a29@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=corbet@lwn.net \
--cc=danieller@mellanox.com \
--cc=idosch@mellanox.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@mellanox.com \
--cc=leon@kernel.org \
--cc=luobin9@huawei.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).