From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=k0u5=BK=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 3833AC433DF
	for <netdev@archiver.kernel.org>; Fri, 31 Jul 2020 00:39:32 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 112D1208A9
	for <netdev@archiver.kernel.org>; Fri, 31 Jul 2020 00:39:32 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1596155972;
	bh=iroX4p9O4VFY7E6zUDbpOIF0/Eimnn0FRMlZ3dSM06A=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From;
	b=kFK3RmbuZNcl/jHkgeGG+do2be5fLgUiTVhEy+exou8qf0RX29T4eGI0xwXFfxb+t
	 SjgcJuDEn2IsNJXXvguWOuTsnuDrSWefDYZOhN0B4hb0RpfXz+BLg6XCLBVrKf+mRy
	 tXphgLFWSfjYIHZSUVr+NqhOmy3Oqo13rygoAYtM=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730915AbgGaAjb (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Thu, 30 Jul 2020 20:39:31 -0400
Received: from mail.kernel.org ([198.145.29.99]:44852 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728086AbgGaAja (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 30 Jul 2020 20:39:30 -0400
Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.4])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 30EAF2074B;
        Fri, 31 Jul 2020 00:39:30 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1596155970;
        bh=iroX4p9O4VFY7E6zUDbpOIF0/Eimnn0FRMlZ3dSM06A=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=uZLfpnGfT1qAPEKsWpSGbVoh2QHv4j3zYI4SfSBdKhh3Dn2c+sjTBYQUtBZKwC41E
         7L3rbtsuU9JIlUQQZFzOk6tx4nrLjBRs8LKDHgAEVMFr3m32SAaKx8wtdmAk7n/n4H
         bZzgpjA2/ghoXoE6rWTk0K5VqvimTa1QJs8VYGXE=
Date:   Thu, 30 Jul 2020 17:39:28 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Jacob Keller <jacob.e.keller@intel.com>
Cc:     netdev@vger.kernel.org, Jiri Pirko <jiri@mellanox.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Michael Chan <michael.chan@broadcom.com>,
        Bin Luo <luobin9@huawei.com>,
        Saeed Mahameed <saeedm@mellanox.com>,
        Leon Romanovsky <leon@kernel.org>,
        Ido Schimmel <idosch@mellanox.com>,
        Danielle Ratson <danieller@mellanox.com>
Subject: Re: [net-next 0/4] devlink flash update overwrite mask
Message-ID: <20200730173928.676a7a29@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20200730232008.2648488-1-jacob.e.keller@intel.com>
References: <20200730232008.2648488-1-jacob.e.keller@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

LGTM,

minor suggestions:
 - could you add opt-in support flags to struct devlink_ops, a'la
   ethtool_ops->supported_coalesce_params so that you don't have to
   modify all drivers to reject unsupported things?
 - could you split patch 2 into an ice change and a devlink core
   change?