From: Dan Carpenter <dan.carpenter@oracle.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Peilin Ye <yepeilin.cs@gmail.com>,
Santosh Shilimkar <santosh.shilimkar@oracle.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [Linux-kernel-mentees] [PATCH net] rds: Prevent kernel-infoleak in rds_notify_queue_get()
Date: Fri, 31 Jul 2020 12:59:43 +0300 [thread overview]
Message-ID: <20200731095943.GI5493@kadam> (raw)
In-Reply-To: <20200731045301.GI75549@unreal>
On Fri, Jul 31, 2020 at 07:53:01AM +0300, Leon Romanovsky wrote:
> On Thu, Jul 30, 2020 at 03:20:26PM -0400, Peilin Ye wrote:
> > rds_notify_queue_get() is potentially copying uninitialized kernel stack
> > memory to userspace since the compiler may leave a 4-byte hole at the end
> > of `cmsg`.
> >
> > In 2016 we tried to fix this issue by doing `= { 0 };` on `cmsg`, which
> > unfortunately does not always initialize that 4-byte hole. Fix it by using
> > memset() instead.
>
> Of course, this is the difference between "{ 0 }" and "{}" initializations.
>
No, there is no difference. Even struct assignments like:
foo = *bar;
can leave struct holes uninitialized. Depending on the compiler the
assignment can be implemented as a memset() or as a series of struct
member assignments.
regards,
dan carpenter
next prev parent reply other threads:[~2020-07-31 10:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 19:20 [Linux-kernel-mentees] [PATCH net] rds: Prevent kernel-infoleak in rds_notify_queue_get() Peilin Ye
2020-07-30 19:29 ` santosh.shilimkar
2020-07-31 4:53 ` Leon Romanovsky
2020-07-31 5:33 ` Greg Kroah-Hartman
2020-07-31 5:33 ` Greg Kroah-Hartman
[not found] ` <CAHp75Vdr2HC_ogNhBCxxGut9=Z6pQMFiA0w-268OQv+5unYOTg@mail.gmail.com>
2020-07-31 7:00 ` Leon Romanovsky
2020-07-31 7:05 ` Andy Shevchenko
2020-07-31 14:04 ` Jason Gunthorpe
2020-07-31 14:21 ` Greg Kroah-Hartman
2020-07-31 14:36 ` Jason Gunthorpe
2020-07-31 17:19 ` Greg Kroah-Hartman
2020-07-31 18:27 ` Jason Gunthorpe
2020-08-01 8:00 ` Dan Carpenter
2020-08-01 14:40 ` Jason Gunthorpe
2020-08-03 9:34 ` Dan Carpenter
2020-08-01 5:38 ` Leon Romanovsky
2020-08-02 22:10 ` Jason Gunthorpe
2020-08-02 22:23 ` Joe Perches
2020-08-02 22:28 ` Jason Gunthorpe
2020-08-02 22:45 ` Joe Perches
2020-08-03 4:58 ` Leon Romanovsky
2020-08-03 23:06 ` Jason Gunthorpe
2020-08-08 22:57 ` Jack Leadford
2020-08-09 7:04 ` Leon Romanovsky
2020-08-14 17:07 ` Jason Gunthorpe
2020-07-31 9:59 ` Dan Carpenter [this message]
2020-07-31 11:14 ` Håkon Bugge
2020-07-31 11:59 ` Greg Kroah-Hartman
2020-07-31 12:03 ` Håkon Bugge
2020-07-31 23:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731095943.GI5493@kadam \
--to=dan.carpenter@oracle.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=santosh.shilimkar@oracle.com \
--cc=yepeilin.cs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).