From: Florent Fourcot <florent.fourcot@wifirst.fr>
To: netdev@vger.kernel.org
Cc: Florent Fourcot <florent.fourcot@wifirst.fr>
Subject: [PATCH net-next 1/2] ipv6/addrconf: call addrconf_ifdown with consistent values
Date: Fri, 31 Jul 2020 15:32:06 +0200 [thread overview]
Message-ID: <20200731133207.26964-1-florent.fourcot@wifirst.fr> (raw)
Second parameter of addrconf_ifdown "how" is used as a boolean
internally. It does not make sense to call it with something different
of 0 or 1.
This value is set to 2 in all git history.
Signed-off-by: Florent Fourcot <florent.fourcot@wifirst.fr>
---
net/ipv6/addrconf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 840bfdb3d7bd..861265fa9d6d 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -7189,7 +7189,7 @@ void addrconf_cleanup(void)
continue;
addrconf_ifdown(dev, 1);
}
- addrconf_ifdown(init_net.loopback_dev, 2);
+ addrconf_ifdown(init_net.loopback_dev, 1);
/*
* Check hash table.
--
2.20.1
next reply other threads:[~2020-07-31 13:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 13:32 Florent Fourcot [this message]
2020-07-31 13:32 ` [PATCH net-next 2/2] ipv6/addrconf: use a boolean to choose between UNREGISTER/DOWN Florent Fourcot
2020-08-03 22:25 ` David Miller
2020-08-03 22:24 ` [PATCH net-next 1/2] ipv6/addrconf: call addrconf_ifdown with consistent values David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731133207.26964-1-florent.fourcot@wifirst.fr \
--to=florent.fourcot@wifirst.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).