From: Andrew Lunn <andrew@lunn.ch>
To: Vikas Singh <vikas.singh@puresoftware.com>
Cc: f.fainelli@gmail.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, netdev@vger.kernel.org,
calvin.johnson@oss.nxp.com, kuldip.dwivedi@puresoftware.com,
madalin.bucur@oss.nxp.com, vikas.singh@nxp.com
Subject: Re: [PATCH] net: Phy: Add PHY lookup support on MDIO bus in case of ACPI probe
Date: Fri, 31 Jul 2020 18:54:55 +0200 [thread overview]
Message-ID: <20200731165455.GD1748118@lunn.ch> (raw)
In-Reply-To: <1595938298-13190-1-git-send-email-vikas.singh@puresoftware.com>
On Tue, Jul 28, 2020 at 05:41:38PM +0530, Vikas Singh wrote:
> Auto-probe of c45 devices with extended scanning in xgmac_mdio works
> well but fails to update device "fwnode" while registering PHYs on
> MDIO bus.
> This patch is based on https://www.spinics.net/lists/netdev/msg662173.html
>
> This change will update the "fwnode" while PHYs get registered and allow
> lookup for registered PHYs on MDIO bus from other drivers while probing.
>
> Signed-off-by: Vikas Singh <vikas.singh@puresoftware.com>
> ---
> drivers/net/phy/mdio_bus.c | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
> index 46b3370..7275eff 100644
> --- a/drivers/net/phy/mdio_bus.c
> +++ b/drivers/net/phy/mdio_bus.c
> @@ -447,8 +447,25 @@ static void of_mdiobus_link_mdiodev(struct mii_bus *bus,
Why would a function called of_mdiobus_link_mdiodev() be poking
around trying to find ACPI properties?
Andrew
next prev parent reply other threads:[~2020-07-31 16:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 12:11 [PATCH] net: Phy: Add PHY lookup support on MDIO bus in case of ACPI probe Vikas Singh
2020-07-31 16:54 ` Andrew Lunn [this message]
[not found] ` <CADvVLtUAd0X7c39BX791CuyWBcmfBsp7Xvw9Jyp05w45agJY9g@mail.gmail.com>
2020-08-01 5:08 ` Florian Fainelli
2020-08-01 9:38 ` Russell King - ARM Linux admin
2020-09-08 16:00 ` Vikas Singh
-- strict thread matches above, loose matches on Subject: below --
2020-07-22 11:22 Vikas Singh
2020-07-22 14:22 ` Andrew Lunn
2020-07-22 20:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731165455.GD1748118@lunn.ch \
--to=andrew@lunn.ch \
--cc=calvin.johnson@oss.nxp.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuldip.dwivedi@puresoftware.com \
--cc=linux@armlinux.org.uk \
--cc=madalin.bucur@oss.nxp.com \
--cc=netdev@vger.kernel.org \
--cc=vikas.singh@nxp.com \
--cc=vikas.singh@puresoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).