From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 863F2C433E0 for ; Fri, 31 Jul 2020 18:41:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 773C8208E4 for ; Fri, 31 Jul 2020 18:41:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387794AbgGaSlG (ORCPT ); Fri, 31 Jul 2020 14:41:06 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:37392 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387676AbgGaSlG (ORCPT ); Fri, 31 Jul 2020 14:41:06 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1k1Zxp-007jEH-50; Fri, 31 Jul 2020 20:41:05 +0200 Date: Fri, 31 Jul 2020 20:41:05 +0200 From: Andrew Lunn To: David Thompson , f@lunn.ch Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, jiri@mellanox.com, Asmaa Mnebhi Subject: Re: [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver Message-ID: <20200731184105.GH1748118@lunn.ch> References: <1596047355-28777-1-git-send-email-dthompson@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1596047355-28777-1-git-send-email-dthompson@mellanox.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > +static int mlxbf_gige_mdio_read(struct mii_bus *bus, int phy_add, int phy_reg) > +{ > + struct mlxbf_gige *priv = bus->priv; > + u32 cmd; > + u32 ret; Here and in write, please check if it is a C45 transaction request and return -EOPNOTSUPP. Andrew