From: David Miller <davem@davemloft.net>
To: ap420073@gmail.com
Cc: kuba@kernel.org, netdev@vger.kernel.org, roopa@cumulusnetworks.com
Subject: Re: [PATCH net] vxlan: fix memleak of fdb
Date: Sat, 01 Aug 2020 11:50:07 -0700 (PDT) [thread overview]
Message-ID: <20200801.115007.230257676134216058.davem@davemloft.net> (raw)
In-Reply-To: <20200801070750.7993-1-ap420073@gmail.com>
From: Taehee Yoo <ap420073@gmail.com>
Date: Sat, 1 Aug 2020 07:07:50 +0000
> When vxlan interface is deleted, all fdbs are deleted by vxlan_flush().
> vxlan_flush() flushes fdbs but it doesn't delete fdb, which contains
> all-zeros-mac because it is deleted by vxlan_uninit().
> But vxlan_uninit() deletes only the fdb, which contains both all-zeros-mac
> and default vni.
> So, the fdb, which contains both all-zeros-mac and non-default vni
> will not be deleted.
>
> Test commands:
> ip link add vxlan0 type vxlan dstport 4789 external
> ip link set vxlan0 up
> bridge fdb add to 00:00:00:00:00:00 dst 172.0.0.1 dev vxlan0 via lo \
> src_vni 10000 self permanent
> ip link del vxlan0
>
> kmemleak reports as follows:
...
> Fixes: 3ad7a4b141eb ("vxlan: support fdb and learning in COLLECT_METADATA mode")
> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Applied and queued up for -stable, thank you.
prev parent reply other threads:[~2020-08-01 18:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-01 7:07 [PATCH net] vxlan: fix memleak of fdb Taehee Yoo
2020-08-01 17:09 ` Roopa Prabhu
2020-08-01 18:50 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200801.115007.230257676134216058.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ap420073@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).