From: Jakub Kicinski <kuba@kernel.org>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Cc: Ganji Aravind <ganji.aravind@chelsio.com>,
netdev@vger.kernel.org, davem@davemloft.net, vishal@chelsio.com
Subject: Re: [PATCH net-next] cxgb4: Add support to flash firmware config image
Date: Sat, 1 Aug 2020 21:22:02 -0700 [thread overview]
Message-ID: <20200801212202.7e4f3be2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200731211733.GA25665@chelsio.com>
On Sat, 1 Aug 2020 02:47:38 +0530 Rahul Lakkireddy wrote:
> I thought /lib/firmware is where firmware related files need to be
> placed and ethtool --flash needs to be used to program them to
> their respective locations on adapter's flash.
Our goal is to provide solid, common interfaces for Linux users to rely
on. Not give way to vendor specific "solutions" like uploading ini files
to perform device configuration.
> Note that we don't have devlink support in our driver yet. And,
> we're a bit confused here on why this already existing ethtool
> feature needs to be duplicated to devlink.
To be clear - I'm suggesting the creation of a more targeted APIs
to control the settings you have encoded _inside_ the ini file.
Not a new interface for an whole sale config upload.
Worst case scenario - if the settings are really device specific
you can try to use devlink device parameters.
next prev parent reply other threads:[~2020-08-02 4:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 15:11 [PATCH net-next] cxgb4: Add support to flash firmware config image Ganji Aravind
2020-07-30 23:23 ` Jakub Kicinski
2020-07-31 11:09 ` Ganji Aravind
2020-07-31 18:00 ` Jakub Kicinski
2020-07-31 21:17 ` Rahul Lakkireddy
2020-08-02 4:22 ` Jakub Kicinski [this message]
2020-08-02 17:12 ` Rahul Lakkireddy
2020-08-03 21:13 ` Jakub Kicinski
2020-08-04 9:43 ` Rahul Lakkireddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200801212202.7e4f3be2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=ganji.aravind@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=rahul.lakkireddy@chelsio.com \
--cc=vishal@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).