netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: rahul.lakkireddy@chelsio.com
Cc: netdev@vger.kernel.org, vishal@chelsio.com, dt@chelsio.com
Subject: Re: [PATCH net-next] cxgb4: fix extracting IP addresses in TC-FLOWER rules
Date: Mon, 03 Aug 2020 15:34:21 -0700 (PDT)	[thread overview]
Message-ID: <20200803.153421.1214139307689007135.davem@davemloft.net> (raw)
In-Reply-To: <1596228820-25570-1-git-send-email-rahul.lakkireddy@chelsio.com>

From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Date: Sat,  1 Aug 2020 02:23:40 +0530

> commit c8729cac2a11 ("cxgb4: add ethtool n-tuple filter insertion")
> has removed checking control key for determining IP address types
> for TC-FLOWER rules, which causes all the rules being inserted to
> hardware to become IPv6 rule type always. So, add back the check
> to select the correct IP address type to extract and hence fix the
> correct rule type being inserted to hardware.
> 
> Also, ethtool_rx_flow_key doesn't have any control key and instead
> directly sets the IPv4/IPv6 address keys. So, explicitly set the
> IP address type for ethtool n-tuple filters to reuse the same code.
> 
> Fixes: c8729cac2a11 ("cxgb4: add ethtool n-tuple filter insertion")
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>

Applied.

      reply	other threads:[~2020-08-03 22:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-31 20:53 [PATCH net-next] cxgb4: fix extracting IP addresses in TC-FLOWER rules Rahul Lakkireddy
2020-08-03 22:34 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200803.153421.1214139307689007135.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dt@chelsio.com \
    --cc=netdev@vger.kernel.org \
    --cc=rahul.lakkireddy@chelsio.com \
    --cc=vishal@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).