From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18551C433E0 for ; Mon, 3 Aug 2020 22:37:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 384EA2068F for ; Mon, 3 Aug 2020 22:37:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728015AbgHCWhE (ORCPT ); Mon, 3 Aug 2020 18:37:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726276AbgHCWhE (ORCPT ); Mon, 3 Aug 2020 18:37:04 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BAADC06174A; Mon, 3 Aug 2020 15:37:04 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 34E49127768A1; Mon, 3 Aug 2020 15:20:18 -0700 (PDT) Date: Mon, 03 Aug 2020 15:37:02 -0700 (PDT) Message-Id: <20200803.153702.1752375702007415165.davem@davemloft.net> To: linmiaohe@huawei.com Cc: johannes@sipsolutions.net, kuba@kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mac80211: use eth_zero_addr() to clear mac address From: David Miller In-Reply-To: <1596273158-24183-1-git-send-email-linmiaohe@huawei.com> References: <1596273158-24183-1-git-send-email-linmiaohe@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 03 Aug 2020 15:20:18 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: linmiaohe Date: Sat, 1 Aug 2020 17:12:38 +0800 > From: Miaohe Lin > > Use eth_zero_addr() to clear mac address instead of memset(). > > Signed-off-by: Miaohe Lin If you're going to make this change, you should probably convert this macro to use eth_addr_copy() at the same time.